-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Builder API schema #2
Conversation
1fe2af9
to
079f909
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like we lost a "status" endpoint?
Live version for this spec: https://builderspec-mevboost.metachris.com/#/Builder |
Co-authored-by: lightclient@protonmail.com <lightclient@protonmail.com> Co-authored-by: Chris Hager <chris@linuxuser.at>
a84bdd8
to
9800cdb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a few minor things to address but starting to look really good!!
Co-authored-by: lightclient@protonmail.com <lightclient@protonmail.com> Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! did a pass. looking good
Co-authored-by: lightclient@protonmail.com <lightclient@protonmail.com> Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
I really appreciate everyone's feedback. I'm going to go ahead and merge this as the feedback has slowed and things seems to be in a pretty solid place. |
This PR adds the schema for the Builder API.