This repository was archived by the owner on Oct 28, 2021. It is now read-only.
Conditionally enable bitshift on ConstantinopleForkBlock #4838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## bitshift #4838 +/- ##
============================================
- Coverage 60.67% 59.16% -1.52%
============================================
Files 347 346 -1
Lines 27293 27249 -44
Branches 3151 2854 -297
============================================
- Hits 16561 16121 -440
- Misses 9738 10157 +419
+ Partials 994 971 -23 |
gumb0
reviewed
Feb 21, 2018
libethcore/EVMSchedule.h
Outdated
| @@ -33,6 +33,7 @@ struct EVMSchedule | |||
| bool haveDelegateCall = true; | |||
| bool eip150Mode = false; | |||
| bool eip158Mode = false; | |||
| bool eip145Mode = false; | |||
There was a problem hiding this comment.
We should better give it more descriptive name like haveBitwiseShifting
|
Hey Tim, one more thing that needs to be done here is actually using the flag that you've added. So the goal is to get rid of compile-time checks |
axic
reviewed
Feb 21, 2018
| // Pre-constantinople | ||
| if (!m_schedule->haveBitwiseShifting) | ||
| throwBadInstruction(); | ||
|
|
||
| ON_OP(); | ||
| updateIOGas(); | ||
|
|
There was a problem hiding this comment.
There is a missed else-endif block below.
|
Can you please squash some of these commits? :) |
|
You got it, to do so makes me happy :D |
|
Hoping this works ^_^ |
axic
approved these changes
Feb 22, 2018
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conditionally enable bitshift on ConstantinopleForkBlock