Skip to content
This repository was archived by the owner on Oct 28, 2021. It is now read-only.

splitting Metropolis into Byzantium and Constantinople #4295

Merged
merged 5 commits into from
Aug 4, 2017
Merged

splitting Metropolis into Byzantium and Constantinople #4295

merged 5 commits into from
Aug 4, 2017

Conversation

pirapira
Copy link
Member

@pirapira pirapira commented Aug 1, 2017 •
edited
Loading

Fixes #4268 .

winsvega
winsvega reviewed Aug 1, 2017
View reviewed changes
libethashseal/genesis/test/mainNetworkTest.cpp Outdated
@@ -26,7 +26,8 @@ R"E(
"daoHardforkBlock": "0x1d4c00",
"EIP150ForkBlock": "0x259518",
"EIP158ForkBlock": "0x28d138",
"metropolisForkBlock": "0x2dc6c0",
"byzantiumForkBlock": "0x2dc6c0",
"constantinopleForkBlock": "0x2dc6c0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need a higher value here to split the fork activation point

libethashseal/genesis/test/transitionnetTest.cpp Outdated
@@ -26,7 +26,8 @@ R"E(
"daoHardforkBlock": "0x08",
"EIP150ForkBlock": "0x0a",
"EIP158ForkBlock": "0x0e",
"metropolisForkBlock": "0x10",
"byzantiumForkBlock": "0x10",
"constantinopleForkBlock": "0x10",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@pirapira
Copy link
Member Author

pirapira commented Aug 1, 2017

@winsvega I delayed Constantinople.

@pirapira
Copy link
Member Author

pirapira commented Aug 2, 2017

I will continue adjusting evmjit.

@winsvega are you going to fix the tests?

@winsvega
Copy link
Contributor

winsvega commented Aug 2, 2017

yes

@pirapira
Copy link
Member Author

pirapira commented Aug 2, 2017

I updated evmjit.

@pirapira pirapira mentioned this pull request Aug 2, 2017
Merged
@pirapira pirapira changed the title [WIP] splitting Metropolis into Byzantium and Constantinople splitting Metropolis into Byzantium and Constantinople Aug 3, 2017
@codecov-io
Copy link

codecov-io commented Aug 3, 2017 •
edited
Loading

Codecov Report

Merging #4295 into develop will decrease coverage by 0.07%.
The diff coverage is 91.48%.

@@             Coverage Diff             @@
##           develop    #4295      +/-   ##
===========================================
- Coverage    67.44%   67.37%   -0.08%     
===========================================
  Files          306      307       +1     
  Lines        23549    23587      +38     
===========================================
+ Hits         15883    15892       +9     
- Misses        7666     7695      +29
Impacted Files Coverage Δ
libethashseal/genesis/test/frontierNoProofTest.cpp 100% <ø> (ø) ⬆️
...hashseal/genesis/test/homesteadToEIP150At5Test.cpp 100% <ø> (ø) ⬆️
libethashseal/genesis/ropsten.cpp 100% <ø> (ø) ⬆️
libethashseal/genesis/test/mainNetworkTest.cpp 100% <ø> (ø) ⬆️
...bethashseal/genesis/test/homesteadToDaoAt5Test.cpp 100% <ø> (ø) ⬆️
libethashseal/genesis/test/homesteadTest.cpp 100% <ø> (ø) ⬆️
libevm/VM.cpp 95.79% <ø> (ø) ⬆️
libethashseal/genesis/test/transitionnetTest.cpp 100% <ø> (ø) ⬆️
libethashseal/genesis/mainNetwork.cpp 100% <ø> (ø) ⬆️
libethashseal/genesis/test/eip150Test.cpp 100% <ø> (ø) ⬆️
... and 30 more

@pirapira pirapira requested review from gumb0 and chfast August 3, 2017 13:21
@pirapira pirapira merged commit 46f02bc into develop Aug 4, 2017
@pirapira pirapira deleted the byzantium branch August 4, 2017 07:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@winsvega winsvega winsvega left review comments

@chfast chfast chfast approved these changes

@gumb0 gumb0 Awaiting requested review from gumb0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pirapira @winsvega @codecov-io @chfast @chriseth