Add ERC: Wallet Call Preparation API #758
Draft
+210
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The commit 483c202 (as a parent of 3c41594) contains errors. |
abcoathup
reviewed
Dec 6, 2024
| @@ -0,0 +1,200 @@ | |||
| --- | |||
There was a problem hiding this comment.
Suggested change
| --- | |
| --- | |
| eip: 7836 |
Assigning next sequential EIP/ERC/RIP number.
Numbers are assigned by editors & associates.
Please also update the filename.
abcoathup
reviewed
Dec 6, 2024
| title: Wallet Call Preparation API | ||
| description: Adds JSON-RPC methods for requesting prepared EIP-5792 calls. | ||
| author: Lukas Rosario (@lukasrosario), Conner Swenberg (@ilikesymmetry), Adam Hodges (@ajhodges), Paaras Bhandari (@paarasbhandari) | ||
| discussions-to: TODO |
There was a problem hiding this comment.
Please create a discussions topic in Eth Magicians with a link to this PR: https://ethereum-magicians.org/c/ercs/57
ajhodges
reviewed
Dec 11, 2024
| #### Parameters | ||
|
|
||
| ```typescript! | ||
| type PrepareCallsParams = [{ |
There was a problem hiding this comment.
@lukasrosario should we add a 'version' field to the params for these two methods similar to the one in 5792?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal defines complementary JSON-RPC methods to EIP-5792's
wallet_sendCalls. Whilewallet_sendCallsis used for an app to submitcallsto be signed and submitted in a wallet's interface, the methods in this proposal are for an application to request prepared calls (where "prepared" depends on the wallet implementation) to be signed and submitted by the application itself.