-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ERC-7066: Move to Last Call #47
Conversation
@eth-bot rerun |
✅ All reviewers have approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 64 says:
lock
function MUST revert if token is not already locked.
Emphasis mine. This seems backwards?
A bit later you write:
ERC-721
_tansfer
function [...]
ERC-721 doesn't have a _tansfer
function (nor _transfer
), so these requirements don't make sense. You may be thinking of the OpenZeppelin implementation, which does have _transfer
.
You can't depend on a specific implementation of ERC-721 in a standard, so you should reword this to be more general. Something like:
ERC-721 functions that transfer ownership of a token MUST revert [...]
Line 66's use of "setup" is a bit ambiguous. I'd recommend being more explicit.
In Line 64:
This is logically inconsistent and could be made clearer by saying something to the effect of:
|
Thanks a lot for the reviews @Joeysantoro @SamWilsn! :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
The commit 01978d8 (as a parent of bb18f33) contains errors. |
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: