New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ERC-6358: Add Compatibility with the Metamask(EIP-712) #40

Merged

eip-review-bot merged 7 commits into ethereum:master from xiyu1984:master

Nov 12, 2023

Contributor

xiyu1984 commented Oct 27, 2023

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

The PR edits only existing draft PRs.
The build passes.
Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
If matching on email address, the email address is the one publicly listed on your GitHub profile.

xiyu1984 added 2 commits

October 27, 2023 11:16


          update ERC-6358: Add compatibility with Metamask

858c453


          update EIP-712 links

e202676

github-actions bot added c-update s-review t-erc w-ci labels

Contributor Author

xiyu1984 commented Oct 27, 2023

Hey Editors,

I need to make a reference to EIP-712, which is in a different repo and I cannot make a relative reference path to it. So the checking of the EIP Walidator fails. I'm not sure how to solve it. Thanks for your time.

Best~

This was referenced Oct 31, 2023

EIP Editing Office Hour Meeting 26 ethcatherders/EIPIP#277

Closed

EIP Editing Office Hour Meeting 27 ethcatherders/EIPIP#290

Closed

github-actions bot commented Nov 11, 2023

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions bot added the w-stale label

Contributor Author

xiyu1984 commented Nov 12, 2023 •

edited

Loading

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

Hey,

Is there anything I need to do? I think everything is OK to update this PR.

Best~


          Merge branch 'master' into master

f584b80

xiyu1984 requested a review from eip-review-bot as a code owner

November 12, 2023 02:57

Collaborator

eip-review-bot commented Nov 12, 2023 •

edited

Loading

✅ All reviewers have approved.

eip-review-bot changed the title ~~Update to ERC-6358: Add Compatibility with the Metamask(EIP-712)~~ Update ERC-6358: Add Compatibility with the Metamask(EIP-712)

eip-review-bot enabled auto-merge (squash)

November 12, 2023 02:58

eip-review-bot previously approved these changes

View reviewed changes

Collaborator

eip-review-bot left a comment

All Reviewers Have Approved; Performing Automatic Merge...

github-actions bot added w-ci and removed w-ci labels


          update links

95e8bf2

auto-merge was automatically disabled

November 12, 2023 03:18

Head branch was pushed to by a user without write access

xiyu1984 dismissed eip-review-bot’s stale review via

95e8bf2

November 12, 2023 03:18

eip-review-bot enabled auto-merge (squash)

November 12, 2023 03:20

eip-review-bot previously approved these changes

View reviewed changes

Collaborator

eip-review-bot left a comment

All Reviewers Have Approved; Performing Automatic Merge...


          fix links

2b7aa4f

auto-merge was automatically disabled

November 12, 2023 03:41

Head branch was pushed to by a user without write access

xiyu1984 dismissed eip-review-bot’s stale review via

2b7aa4f

November 12, 2023 03:41

eip-review-bot enabled auto-merge (squash)

November 12, 2023 03:42

eip-review-bot previously approved these changes

View reviewed changes

Collaborator

eip-review-bot left a comment

All Reviewers Have Approved; Performing Automatic Merge...


          fix links

0eeb41d

auto-merge was automatically disabled

November 12, 2023 03:43

Head branch was pushed to by a user without write access

xiyu1984 dismissed eip-review-bot’s stale review via

0eeb41d

November 12, 2023 03:43

github-actions bot removed the w-ci label

eip-review-bot enabled auto-merge (squash)

November 12, 2023 03:44

eip-review-bot previously approved these changes

View reviewed changes

Collaborator

eip-review-bot left a comment

All Reviewers Have Approved; Performing Automatic Merge...


          fix links

a6e5e92

auto-merge was automatically disabled

November 12, 2023 03:45

Head branch was pushed to by a user without write access

xiyu1984 dismissed eip-review-bot’s stale review via

a6e5e92

November 12, 2023 03:45

eip-review-bot enabled auto-merge (squash)

November 12, 2023 03:46

eip-review-bot approved these changes

View reviewed changes

Collaborator

eip-review-bot left a comment

All Reviewers Have Approved; Performing Automatic Merge...

eip-review-bot merged commit 2afe977 into ethereum:master

github-actions bot commented Nov 12, 2023

The commit a6e5e92 (as a parent of 312df9d) contains errors.
Please inspect the Run Summary for details.

github-actions bot added the w-ci label

etan-status mentioned this pull request

Update EIP-7495: Allow setting properties in StableContainer impl ethereum/EIPs#7936

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c-update s-review t-erc w-ci w-stale