Move EIP assets to assets folder #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):
|
|
Note: the changes to EIP1, EIP107 and EIP858 are solely to update the links to their respective images. None of the actual content or wording has been modified! |
Arachnid
reviewed
Apr 6, 2018
EIPS/eip-1.md
Outdated
| @@ -64,7 +64,7 @@ EIPs can also be superseded by a different EIP, rendering the original obsolete. | |||
|
|
|||
| The possible paths of the status of EIPs are as follows: | |||
|
|
|||
|  | |||
|  | |||
There was a problem hiding this comment.
Please don't use absolute paths - this will break for anyone running it on theirname.github.io.
There was a problem hiding this comment.
ok I'll fix it to ../assets/eip-1/process.png (and the other links too)
EIPS/eip-1.md
Outdated
| @@ -114,7 +114,8 @@ Each EIP should have the following parts: | |||
| EIP Formats and Templates | |||
| ------------------------- | |||
|
|
|||
| EIPs should be written in [markdown] format. Image files should be included in a subdirectory for that EIP. | |||
| EIPs should be written in [markdown] format. | |||
| Image files should be included in a subdirectory of the `assets` folder for that EIP as follow: `assets/eip-X` (for eip *X*). | |||
There was a problem hiding this comment.
I thought it looked nicer italics, but I'm happy to make it bold.
- Create `assets` folder - Move existing EIPs (1, 107, 858) assets into the `assets` folder - Update link to assets in EIPs 1, 107 and 858 - Describe the inclusion of assets for EIPs in `README.md`
Arachnid
approved these changes
Apr 6, 2018
Arachnid
pushed a commit
to Arachnid/EIPs
that referenced
this pull request
May 2, 2018
- Create `assets` folder - Move existing EIPs (1, 107, 858) assets into the `assets` folder - Update link to assets in EIPs 1, 107 and 858 - Describe the inclusion of assets for EIPs in `README.md`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a brief discussion with @Arachnid I suggest the following changes to the EIPs repository to make sure that EIPS with images and other assets pass the CI checks.
assetsfolderassetsfolderREADME.md