Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding co-author of ERC55 #951

Merged
merged 1 commit into from
Mar 8, 2019
Merged

Conversation

alexvandesande
Copy link

@alexvandesande alexvandesande commented Mar 26, 2018

When Vitalik initially proposed the idea it was quite different, using the binary form of the address, which added complexity. I created the first implementation in that form, and suggested the simplified version If it's 0-7 then it should be lowercase, otherwise, it should be uppercase. I also pushed the first implementations. His original post has been edited by EIP editors as we didn't have the PR format yet.

Would that be enough to be a co-author? I don't mind if this is rejected, just wanted to point that up.

When Vitalik initially proposed the idea it was quite different, using the binary form of the address, which added complexity. I created the first implementation in that form, and suggested the simplified version `If it's 8 or upper (including a-f) then it should be uppercase, otherwise, it should be lowercase.` I also pushed the first implementations. His original post has been edited by EIP editors as we didn't have the PR format yet.

Would that be enough to be a co-author? I don't mind if this is rejected, just wanted to point that up.
@Arachnid Arachnid requested a review from vbuterin March 26, 2018 17:35
@alexvandesande alexvandesande changed the title Adding co-author? Adding co-author of ERC55 May 24, 2018
@nicksavers
Copy link
Contributor

The JavaScript implementation on this page https://eips.ethereum.org/EIPS/eip-55 seems to come from this comment #55 (comment). And the idea to change from using binary form to the visible address also came from you, so it seems reasonable to me.

Since @vbuterin didn't create the PR himself, only the issue which clearly had a lot of discussion before coming to a conclusion I'll merge this.

@nicksavers nicksavers merged commit 8f50651 into ethereum:master Mar 8, 2019
ilanolkies pushed a commit to ilanolkies/EIPs that referenced this pull request Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants