Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-7685: change requests hash to flat hash #8854

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fjl
Copy link
Contributor

@fjl fjl commented Sep 4, 2024

There is no need to create a tree hash over the requests, since proofs related to requests will be made over the CL block. The EL block body stores unvalidated requests and will never be used for proofs. Removing the tree hash simplifies things.

There is no need to create a tree hash over the requests, since proofs
related to requests will be made over the CL block. The EL block body stores
unvalidated requests and will never be used for proofs. Removing the tree hash
simplifies things.
@fjl fjl requested a review from eth-bot as a code owner September 4, 2024 10:49
@github-actions github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review t-core labels Sep 4, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Sep 4, 2024

File EIPS/eip-7685.md

Requires 1 more reviewers from @lightclient

@eth-bot eth-bot added the a-review Waiting on author to review label Sep 4, 2024
@eth-bot eth-bot changed the title EIP-7685: change requests hash to flat hash Update EIP-7685: change requests hash to flat hash Sep 4, 2024
@lightclient
Copy link
Member

This makes sense to me in general. We won't be seeing light client proofs against this data as it will be included natively in the CL.

@mkalinin
Copy link
Contributor

mkalinin commented Sep 4, 2024

Moreover, we have requests data in logs lightclient/sys-asm#17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-update Modifies an existing proposal s-review This EIP is in Review t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants