Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EIP: Increase MIN_BASE_FEE_PER_BLOB_GAS #8849

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Add EIP: Increase MIN_BASE_FEE_PER_BLOB_GAS #8849

wants to merge 11 commits into from
+68 −0

Conversation

MaxResnick
Copy link

ATTENTION: ERC-RELATED PULL REQUESTS NOW OCCUR IN ETHEREUM/ERCS

--

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-core labels Sep 2, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Sep 2, 2024 •
edited
Loading

File EIPS/eip-7762.md

Requires 1 more reviewers from @axic, @g11tech, @gcolvin, @lightclient, @SamWilsn

File base_fee_1.png

Requires 3 more reviewers from @axic, @g11tech, @gcolvin, @lightclient, @SamWilsn, @xinbenlv

File base_fee_225.png

Requires 3 more reviewers from @axic, @g11tech, @gcolvin, @lightclient, @SamWilsn, @xinbenlv

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Sep 2, 2024
@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Sep 2, 2024
abcoathup
abcoathup reviewed Sep 3, 2024
View reviewed changes
EIPS/eip-draft_increase_blob_base_fee.md Outdated
title: Increase Blob Base Fee
description: Adjust the MIN_BASE_FEE_PER_BLOB_GAS to speed up price discovery on blob space
author: <Max Resnick (@MaxResnick)>
discussions-to: <URL>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a discussions topic in Eth Magicians using the template in the EIPs category:
https://ethereum-magicians.org/c/eips/5

@abcoathup abcoathup mentioned this pull request Sep 3, 2024
Open
@MaxResnick @abcoathup
Update EIPS/eip-draft_increase_blob_base_fee.md
bad448e 
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
@MaxResnick MaxResnick changed the title Add EIP: Increase Blob Base Fee Add EIP: Increase Blob Base Fee Reserve Price Sep 3, 2024
@eth-bot eth-bot changed the title Add EIP: Increase Blob Base Fee Reserve Price Add EIP: Increase Blob Base Fee Sep 3, 2024
@github-actions github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels Sep 3, 2024
@eth-bot eth-bot changed the title Add EIP: Increase Blob Base Fee Add EIP: Increase MIN_BASE_FEE_PER_BLOB_GAS Sep 3, 2024
abcoathup
abcoathup reviewed Sep 4, 2024
View reviewed changes
EIPS/eip-7762.md Outdated Show resolved Hide resolved
abcoathup
abcoathup reviewed Sep 4, 2024
View reviewed changes
EIPS/eip-7762.md Outdated Show resolved Hide resolved
MaxResnick and others added 2 commits September 4, 2024 09:53
@MaxResnick @abcoathup
Update EIPS/eip-7762.md
9c1eb14 
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
@MaxResnick @abcoathup
Update EIPS/eip-7762.md
021e525 
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Sep 4, 2024
@MaxResnick MaxResnick mentioned this pull request Sep 4, 2024
Open
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Sep 4, 2024
lightclient
lightclient reviewed Sep 6, 2024
View reviewed changes
EIPS/eip-7762.md Outdated

![Base Fee 1](base_fee_1.png)

<div style="page-break-after: always;"></div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inline html is not allowed. please remove

lightclient
lightclient reviewed Sep 6, 2024
View reviewed changes
EIPS/eip-7762.md Outdated Show resolved Hide resolved
lightclient
lightclient reviewed Sep 6, 2024
View reviewed changes
EIPS/eip-7762.md Outdated Show resolved Hide resolved
@lightclient
Copy link
Member

If you would like this EIP to be merged, please undraft the PR.

XstRUhayabusa
XstRUhayabusa suggested changes Sep 6, 2024
View reviewed changes
Copy link

@XstRUhayabusa XstRUhayabusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dankeschön

@MaxResnick MaxResnick marked this pull request as ready for review September 9, 2024 16:58
@MaxResnick @lightclient
Update EIPS/eip-7762.md
07fcaa0 
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Sep 9, 2024
@MaxResnick @lightclient
Update EIPS/eip-7762.md
370d95b 
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Sep 9, 2024
@lightclient
Copy link
Member

@MaxResnick can you please fix the CI issues so we can merge this EIP.

MaxResnick and others added 2 commits September 11, 2024 08:37
@MaxResnick @lightclient
Update EIPS/eip-7762.md
a6e7137 
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
@MaxResnick
remove in line html
eda0480
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Sep 11, 2024
@github-actions GitHub Actions
Copy link

The commit eda0480 (as a parent of d0c9866) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Sep 11, 2024
@MaxResnick
Copy link
Author

@lightclient should be good to go

@MaxResnick MaxResnick mentioned this pull request Sep 11, 2024
Closed
macfarla
macfarla reviewed Sep 19, 2024
View reviewed changes
EIPS/eip-7762.md

## Copyright

Copyright and related rights waived via [CC0](https://creativecommons.org/publicdomain/zero/1.0/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Copyright and related rights waived via [CC0](https://creativecommons.org/publicdomain/zero/1.0/).
Copyright and related rights waived via [CC0](../LICENSE.md).

macfarla
macfarla reviewed Sep 19, 2024
View reviewed changes
base_fee_225.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the images are added twice in separate locations, perhaps unintentional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macfarla macfarla macfarla left review comments

@lightclient lightclient lightclient left review comments

@abcoathup abcoathup abcoathup left review comments

@JanKortes212 JanKortes212 JanKortes212 left review comments

@XstRUhayabusa XstRUhayabusa XstRUhayabusa requested changes

@jamesavechives jamesavechives jamesavechives approved these changes

@Magken91 Magken91 Magken91 approved these changes

@Allzz77123 Allzz77123 Allzz77123 approved these changes

@GIgako19929 GIgako19929 GIgako19929 approved these changes

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-core w-ci Waiting on CI to pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.