-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP: eth/69 - Drop pre-merge fields #8271
Conversation
✅ All reviewers have approved. |
Quick reminder that here On this issue it was discussed: See: ethereum/devp2p#245 (comment) So maybe we want to include this as well in |
I've renamed the proposal to |
@jochem-brouwer Do you think we should change the protocol to use the previously proposed mechanism? I would prefer leaving it as is and enshrining the "bug" |
The commit 127877f (as a parent of b59d95c) contains errors. |
I have no strong opinion here, I think just leaving it in as bug is fine :) |
I did some more benchmarks and determined the floor for bandwidth improvements to be at ~95GiB. |
Co-authored-by: Martin HS <martin@swende.se>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
Draft of eth70
Todo: