Add EIP: NFT Redeemables #7501
Add EIP: NFT Redeemables #7501
Conversation
github-actions
bot
added
c-new
File
|
eth-bot
added
e-consensus
|
EIP/ERC numbering changes to sequential from 7500 and is no longer the PR number: #6990 (comment) This PR was opened 1 minute after #7500 which was opened 3 minutes after #7499 so has the appearance of number sniping but as there is a spec I am not manually renumbering. |
- Add new `campaignRequirements` to allow for OR case redemptions (e.g. token from contract A OR contract B) - Include reference implementation and tests (to be continued to be added to) - Destructure extraData in redeem() func into params for easier serialization and understandability of params - Simplify IRedemptionMintable and add campaignId - Add `translations` to redeemable URI
ryanio
force-pushed
the
ryan/add-eip-nft-redeemables
branch
from
efe2318 to
b3f7c97
Compare
|
The commit 39e4b98 (as a parent of 9f653b8) contains errors. |
| - discovery: events and getters that provide information about the requirements of a redemption campaign | ||
| - onchain: token mints with context of items spent | ||
| - offchain: the ability to associate with ecommerce orders (through `redemptionHash`) | ||
| - trait redemptions: improving the burn-to-redeem experience with E RC-7496 <!-- [E RC-7496] (./e ip-7496.md) --> Dynamic Traits. |
There was a problem hiding this comment.
i am assuming you are waiting for 7496 draft merge to fix this link?
There was a problem hiding this comment.
yes exactly, otherwise CI wasn't happy, can fix as soon as #7500 is merged and I can link properly
|
I am closing this pull request because we are in the process of separating EIPs and ERCs into distinct repositories. Unfortunately, as far as we are aware, GitHub does not provide any tools to ease this migration, so every pull request will need to be re-opened manually. As this is a PR to create / modify an ERC, I will kindly ask you to redirect this to the new repository at ethereum/ERCs. We have prepared a guide to help with the process. If there is relevant history here, please link to this PR from the new pull request. On behalf of the EIP Editors, I apologize for this inconvenience. |
Discussion thread: https://ethereum-magicians.org/t/erc-7498-nft-redeemables/15485