Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-6963: Remove Object.freeze from Dapp implementation exampl… #7175

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Update EIP-6963: Remove Object.freeze from Dapp implementation exampl… #7175

merged 2 commits into from
Jun 14, 2023

Conversation

glitch-txs
Copy link
Contributor

Remove Object.freeze from Dapp implementation example, added to wallet example instead

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@glitch-txs glitch-txs requested a review from eth-bot as a code owner June 13, 2023 04:14
@github-actions github-actions bot added c-update Modifies an existing proposal s-draft This EIP is a Draft t-interface labels Jun 13, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Jun 13, 2023

✅ All reviewers have approved.

@eth-bot eth-bot enabled auto-merge (squash) June 13, 2023 04:15
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@glitch-txs glitch-txs disabled auto-merge June 13, 2023 04:18
@glitch-txs
Copy link
Contributor Author

pinging for confirmation @kdenhartog

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jun 13, 2023
@kdenhartog
Copy link
Contributor

I've been waiting on #7113 to go through to update the bibliography section, but if it's holding up PRs I can go ahead and fix it now.

@eth-bot eth-bot enabled auto-merge (squash) June 14, 2023 02:12
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 63c5406 into ethereum:master Jun 14, 2023
@github-actions
Copy link

The commit b3295ae (as a parent of ec1fb29) contains errors.
Please inspect the Run Summary for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal s-draft This EIP is a Draft t-interface w-ci Waiting on CI to pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants