Add EIP: Contract Secured Revenue on an EVM based L2 #6969

owocki · 2023-05-01T19:14:49Z

Contract Secured Revenue (CSR) allows smart contract developers to claim a percentage of all transaction fees paid by users when interacting with their smart contracts.

This EIP proposes the introduction of CSR on EVM-based L2s. If adopted, this would allow smart contract developers who deploy on L2s to access a potentially lucrative revenue stream and/or fund public goods.

This is a draft PR with a draft specification. Please see the submitted .md file and also checkout the discussion at https://ethereum-magicians.org/t/eip-6969-generalized-csr-protocol/14178

Update eip-6969.md

eth-bot · 2023-05-01T19:15:48Z

✅ All reviewers have approved.

abcoathup · 2023-05-02T00:48:46Z

If @zscole doesn't have a specification ready, I recommend closing this PR and waiting to open it until it is ready.

EIP number sniping and gaming is not allowed, I am manually assigning 6968, in case you want to proceed with this PR. EIP editors can overrule.

Precedent for manually assigning a number for an apparent number lunge when a draft EIP/ERC isn't ready was for an ERC I authored: #4888 (review)

EIPS/eip-6969.md

abcoathup · 2023-05-02T00:50:51Z

EIPS/eip-6969.md

+title: Contract Secured Revenue on an EVM based L2
+status: Draft
+type: Core
+discussions-to: https://t.me/+w1EKtAx824VlZDJh


Please create a discussion thread on https://ethereum-magicians.org/

https://ethereum-magicians.org/t/eip-6969-generalized-csr-protocol/14178

Please rename the discussion thread to the assigned EIP number EIP6968

zscole · 2023-05-06T19:45:03Z

preliminary technical specification has been added in collaboration with @lightclient.

Update eip-6969.md

SamWilsn · 2023-05-09T02:06:14Z

EIPS/eip-6969.md

@@ -0,0 +1,169 @@
+---
+eip: 6969


This PR was opened to reserve the meme number. The first commit (3a485ae) is just a preamble and the EIP template. The EIP remained mostly empty until May 6th (6c7f200).

We do our best to discourage number sniping, and @abcoathup has volunteered to reassign such numbers as they arise.

To be perfectly clear, if this proposal had content at the time it was pull requested, we wouldn't be reassigning this number.

Suggested change

eip: 6969

eip: 6968

Change has been submitted. Can we get this merged now? Thank you!

The automatic validator is still flagging some issues that need to be fixed.
https://github.com/ethereum/EIPs/pull/6969/files

For example:

discussions-to should point to the Ethereum magicians thread

add your GitHub handle as an author

There are also a number of "TODO Zak"

zsystm · 2023-05-11T06:08:45Z

EIPS/eip-6969.md

+
+In order to fairly distribute the fee revenue, a new transaction-wide gas tracker is defined.
+
+When executing a block, maintain a mapping `gas_used_by_address` of `address` to `uint64`. This will track the amount of gas used by each address. For every EVM instruction that does not instantiate a new execution frame (e.g. `CALL`, `CALLCODE`, `DELEGATECALL`, `STATICCALL`, `CREATE`, and `CREATE2`), add the cost of the instruction to the address' current sum in the mapping.


@lightclient
Couple of question for this.

What does it mean "instruction that does not instantiate a new execution frame"?
I checked the https://github.com/ethereum/go-ethereum/blob/master/core/vm/instructions.go but couldn't catch that meaning.

Can you share the actual code reference about "instantiate a new execution frame"?

Thanks in advance!

It's a standard call stack frame. When an external call is made, that pushes a new frame. A frame contains the currently executing contract's context like stack and memory.

So examples in the doc (CALL, CALLCODE, DELEGATECALL, STATICCALL, CREATE, and CREATE2) are instructions that instantiate a new execution frame right?

SamWilsn · 2023-05-16T15:44:57Z

EIPS/eip-6969.md

+
+Contract Secured Revenue (CSR) allows smart contract developers to claim a percentage of all transaction fees paid by users when interacting with their smart contracts.
+
+This EIP proposes the introduction of CSR on EVM-based L2s. If adopted, this would allow smart contract developers who deploy on L2s to access a potentially lucrative revenue stream and/or fund public goods.


You want to write as if the proposal has been adopted, because once it goes to final, it won't make sense to say "if adopted".

SamWilsn · 2023-05-16T15:45:22Z

EIPS/eip-6969.md

+1. It could [become just a race to the bottom devolving into rebates for users](https://twitter.com/trent_vanepps/status/1623361559983452160)
+2. It has [yet to be proven that it can sustainable attract/retain/comp devs](https://twitter.com/trent_vanepps/status/1653086558633836564)


You'll have to remove external links, except for the exceptions defined in EIP-1.

SamWilsn · 2023-05-16T15:45:45Z

EIPS/eip-6969.md

+Constructing the revenue recipient mapping ephemerally during each transaction appears inefficient on the surface. This value is expected to be relatively static and even if it did need to change, the change could be facilitated by the recipient contract.
+
+Unfortunately such a change is much more invasive for the EVM. The recipient value would need to be stored somewhere. This would require a modification to the account structure in the state trie. Also, the recipient value would need to be set at some point. This would necessitate either a modification to the `CREATE*` opcodes or a new opcode, similar to `SETREVENUERECIPIENT`, that would be called by initcode to "initialize" the recipient value.
+## Rationale


You have two rationale sections.

These change requests have been addressed. Thank you.

Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>

fixes typo

Update eip-6968.md

github-actions · 2023-06-02T19:50:22Z

The commit 31ccb07 (as a parent of 368b00e) contains errors.
Please inspect the Run Summary for details.

fixed linting errors in md

SamWilsn · 2023-06-08T20:46:20Z

EIPS/eip-6968.md

+status: Draft
+type: Standards Track
+category: Core
+created: 2023-05-01


Suggested change

created: 2023-05-01

created: 2023-05-01

requires: 150

SamWilsn · 2023-06-08T20:46:36Z

EIPS/eip-6968.md

+
+Additionally:
+
+- If the address does not exist in the mapping, it's total gas used is `0`.


Suggested change

- If the address does not exist in the mapping, it's total gas used is `0`.

- If the address does not exist in the mapping, its total gas used is `0`.

Requested change made.

zscole · 2023-06-12T23:15:52Z

All the outstanding issues have been addressed. Can we get this merged? @SamWilsn

SamWilsn

There are still two outstanding comments, but they're minor enough to fix later.

eth-bot

All Reviewers Have Approved; Performing Automatic Merge...

Kevin Owocki and others added 6 commits May 1, 2023 11:37

laying tracks

3a485ae

Update eip-6969.md

7cc9f18

abstract

aca2014

Merge branch 'master' into patch-1

553791b

more

4be43aa

Merge pull request #1 from zscole/patch-1

3ebe57d

Update eip-6969.md

owocki requested a review from eth-bot as a code owner May 1, 2023 19:14

github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft labels May 1, 2023

owocki changed the title ~~EIP 6969 - Contract Secured Revenue (Draft)~~ EIP 6969 - Contract Secured Revenue on L2s (Draft) May 1, 2023

eth-bot changed the title ~~EIP 6969 - Contract Secured Revenue on L2s (Draft)~~ Add EIP: Contract Secured Revenue on an EVM based L2 May 1, 2023

eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels May 1, 2023

discussions

9861e46

github-actions bot added the w-ci Waiting on CI to pass label May 1, 2023

abcoathup reviewed May 2, 2023

View reviewed changes

EIPS/eip-6969.md Outdated Show resolved Hide resolved

abcoathup reviewed May 2, 2023

View reviewed changes

abcoathup mentioned this pull request May 4, 2023

Rethink EIP numbering #6990

Closed

Update eip-6969.md

6c7f200

Merge pull request #2 from zscole/patch-2

90e5eb2

Update eip-6969.md

SamWilsn requested changes May 9, 2023

View reviewed changes

zscole mentioned this pull request May 9, 2023

Execution Layer Meeting 161 ethereum/pm#768

Closed

zsystm reviewed May 11, 2023

View reviewed changes

zscole mentioned this pull request May 16, 2023

EIP Editing Office Hour Meeting 17 ethcatherders/EIPIP#231

Closed

19 tasks

SamWilsn previously requested changes May 16, 2023

View reviewed changes

Update EIPS/eip-6969.md

0d61c03

Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>

owocki dismissed a stale review via 0d61c03 May 16, 2023 15:52

owocki added 2 commits June 2, 2023 13:18

Merge pull request #4 from zscole/patch-4

cf26d64

fixes typo

Merge pull request #5 from zscole/patch-5

01ac567

Update eip-6968.md

github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels Jun 2, 2023

zscole added 2 commits June 2, 2023 14:39

blanks around headings

92dfd71

Update eip-6968.md

933ca59

github-actions bot removed the w-ci Waiting on CI to pass label Jun 2, 2023

zscole added 2 commits June 2, 2023 14:42

Merge branch 'master' into master

5bf338e

Update eip-6968.md

31ccb07

github-actions bot added the w-ci Waiting on CI to pass label Jun 2, 2023

dsudit01 and others added 2 commits June 5, 2023 12:44

fixed linting errors in md

ab7ccff

Merge pull request #6 from dsudit01/master

64261f9

fixed linting errors in md

github-actions bot added the t-core label Jun 5, 2023

Update eip-6968.md

1543535

github-actions bot removed the w-ci Waiting on CI to pass label Jun 5, 2023

zscole added 2 commits June 5, 2023 09:13

Merge branch 'master' into master

1f2f0b4

Merge branch 'master' into master

d09c9a9

SamWilsn reviewed Jun 8, 2023

View reviewed changes

zscole added 3 commits June 12, 2023 18:16

Merge branch 'master' into master

6b9939c

Merge branch 'master' into master

236271b

Merge branch 'master' into master

46ec4df

SamWilsn approved these changes Jun 19, 2023

View reviewed changes

eth-bot enabled auto-merge (squash) June 19, 2023 16:00

eth-bot approved these changes Jun 19, 2023

View reviewed changes

eth-bot merged commit 1fe0b2e into ethereum:master Jun 19, 2023

abcoathup mentioned this pull request Jul 25, 2023

Update EIP-5000: Renumber to EIP-5159 #5270

Closed

abcoathup mentioned this pull request Aug 18, 2023

Add EIP: NFT Dynamic Traits #7500

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add EIP: Contract Secured Revenue on an EVM based L2 #6969

Add EIP: Contract Secured Revenue on an EVM based L2 #6969

owocki commented May 1, 2023 •

edited

Loading

eth-bot commented May 1, 2023 •

edited

Loading

abcoathup commented May 2, 2023 •

edited

Loading

abcoathup May 2, 2023

owocki May 8, 2023

abcoathup May 9, 2023

zscole commented May 6, 2023

SamWilsn May 9, 2023

zscole May 16, 2023

abcoathup May 17, 2023

zsystm May 11, 2023 •

edited

Loading

lightclient May 14, 2023

zsystm May 14, 2023 •

edited

Loading

SamWilsn May 16, 2023

SamWilsn May 16, 2023

SamWilsn May 16, 2023

zscole Jun 5, 2023

github-actions bot commented Jun 2, 2023

SamWilsn Jun 8, 2023

SamWilsn Jun 8, 2023

zscole commented Jun 12, 2023

SamWilsn left a comment

eth-bot left a comment


		In order to fairly distribute the fee revenue, a new transaction-wide gas tracker is defined.

		When executing a block, maintain a mapping `gas_used_by_address` of `address` to `uint64`. This will track the amount of gas used by each address. For every EVM instruction that does not instantiate a new execution frame (e.g. `CALL`, `CALLCODE`, `DELEGATECALL`, `STATICCALL`, `CREATE`, and `CREATE2`), add the cost of the instruction to the address' current sum in the mapping.

		1. It could [become just a race to the bottom devolving into rebates for users](https://twitter.com/trent_vanepps/status/1623361559983452160)
		2. It has [yet to be proven that it can sustainable attract/retain/comp devs](https://twitter.com/trent_vanepps/status/1653086558633836564)


		Additionally:

		- If the address does not exist in the mapping, it's total gas used is `0`.

Add EIP: Contract Secured Revenue on an EVM based L2 #6969

Add EIP: Contract Secured Revenue on an EVM based L2 #6969

Conversation

owocki commented May 1, 2023 • edited Loading

eth-bot commented May 1, 2023 • edited Loading

abcoathup commented May 2, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zscole commented May 6, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zsystm May 11, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zsystm May 14, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jun 2, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zscole commented Jun 12, 2023

SamWilsn left a comment

Choose a reason for hiding this comment

eth-bot left a comment

Choose a reason for hiding this comment

owocki commented May 1, 2023 •

edited

Loading

eth-bot commented May 1, 2023 •

edited

Loading

abcoathup commented May 2, 2023 •

edited

Loading

zsystm May 11, 2023 •

edited

Loading

zsystm May 14, 2023 •

edited

Loading