-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-6475: Add 0x01
prefix for Some
#6945
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-update
Modifies an existing proposal
s-draft
This EIP is a Draft
t-core
labels
Apr 27, 2023
✅ All reviewers have approved. |
eth-bot
changed the title
Update EIP-6475: Add
Update EIP-6404: Add Apr 27, 2023
0x01
prefix for Some
0x01
prefix for Some
etan-status
added a commit
to status-im/nim-ssz-serialization
that referenced
this pull request
Apr 27, 2023
EIP-6475 was bumped to emit an additional `0x01` byte in the `Some` case of optionals to allow nesting `Optional` and `Optional[List]` and to provide compatibility with `Union` serialization. Note that the `None` case is still serialized as empty. https://eips.ethereum.org/EIPS/eip-6475 ethereum/EIPs#6945
etan-status
changed the title
Update EIP-6404: Add
Update EIP-6475: Add Apr 27, 2023
0x01
prefix for Some
0x01
prefix for Some
etan-status
added a commit
to etan-status/consensus-specs
that referenced
this pull request
Apr 27, 2023
@eth-bot rerun |
eth-bot
changed the title
Update EIP-6475: Add
Update EIP-6404: Add Apr 29, 2023
0x01
prefix for Some
0x01
prefix for Some
eth-bot
approved these changes
Apr 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
etan-status
changed the title
Update EIP-6404: Add
Update EIP-6475: Add Apr 29, 2023
0x01
prefix for Some
0x01
prefix for Some
etan-status
added a commit
to status-im/nim-ssz-serialization
that referenced
this pull request
Apr 30, 2023
EIP-6475 was bumped to emit an additional `0x01` byte in the `Some` case of optionals to allow nesting `Optional` and `Optional[List]` and to provide compatibility with `Union` serialization. Note that the `None` case is still serialized as empty. https://eips.ethereum.org/EIPS/eip-6475 ethereum/EIPs#6945
ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.