Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-6475: Add 0x01 prefix for Some #6945

Merged
merged 2 commits into from
Apr 29, 2023

Conversation

etan-status
Copy link
Contributor

No description provided.

@github-actions github-actions bot added c-update Modifies an existing proposal s-draft This EIP is a Draft t-core labels Apr 27, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Apr 27, 2023

✅ All reviewers have approved.

@eth-bot eth-bot changed the title Update EIP-6475: Add 0x01 prefix for Some Update EIP-6404: Add 0x01 prefix for Some Apr 27, 2023
etan-status added a commit to status-im/nim-ssz-serialization that referenced this pull request Apr 27, 2023
EIP-6475 was bumped to emit an additional `0x01` byte in the `Some` case
of optionals to allow nesting `Optional` and `Optional[List]` and to
provide compatibility with `Union` serialization. Note that the `None`
case is still serialized as empty.

https://eips.ethereum.org/EIPS/eip-6475
ethereum/EIPs#6945
@etan-status etan-status changed the title Update EIP-6404: Add 0x01 prefix for Some Update EIP-6475: Add 0x01 prefix for Some Apr 27, 2023
@etan-status etan-status marked this pull request as ready for review April 29, 2023 15:02
@etan-status etan-status requested a review from eth-bot as a code owner April 29, 2023 15:02
@etan-status
Copy link
Contributor Author

@eth-bot rerun

@eth-bot eth-bot changed the title Update EIP-6475: Add 0x01 prefix for Some Update EIP-6404: Add 0x01 prefix for Some Apr 29, 2023
@eth-bot eth-bot enabled auto-merge (squash) April 29, 2023 15:09
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@etan-status etan-status changed the title Update EIP-6404: Add 0x01 prefix for Some Update EIP-6475: Add 0x01 prefix for Some Apr 29, 2023
@eth-bot eth-bot merged commit eeb03f7 into ethereum:master Apr 29, 2023
@etan-status etan-status deleted the sz-someone branch April 29, 2023 15:35
etan-status added a commit to status-im/nim-ssz-serialization that referenced this pull request Apr 30, 2023
EIP-6475 was bumped to emit an additional `0x01` byte in the `Some` case
of optionals to allow nesting `Optional` and `Optional[List]` and to
provide compatibility with `Union` serialization. Note that the `None`
case is still serialized as empty.

https://eips.ethereum.org/EIPS/eip-6475
ethereum/EIPs#6945
@JanKortes212
Copy link

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal s-draft This EIP is a Draft t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants