Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-1: Update EIP-1 to include wording about The Finalizing Pull Request #6824

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

xinbenlv
Copy link
Contributor

@xinbenlv xinbenlv commented Apr 3, 2023

Update EIP-1 to reflect policy decision documented in #6129 (comment) and decided in ethcatherders/EIPIP#198 (comment)

@xinbenlv xinbenlv requested a review from eth-bot as a code owner April 3, 2023 18:09
@github-actions github-actions bot added c-update Modifies an existing proposal t-process labels Apr 3, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Apr 3, 2023

✅ All reviewers have approved.

@eth-bot eth-bot changed the title Update eip-1.md to include wording about Final PR Update EIP-1: Update eip-1.md to include wording about Final PR Apr 3, 2023
@xinbenlv xinbenlv changed the title Update eip-1.md to include wording about Final PR Update EIP-1 to include wording about The Finalizing Pull Request Apr 3, 2023
@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Apr 3, 2023
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strong +1

@eth-bot eth-bot changed the title Update EIP-1 to include wording about The Finalizing Pull Request Update EIP-1: Update EIP-1 to include wording about The Finalizing Pull Request Apr 4, 2023
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eth-bot eth-bot enabled auto-merge (squash) April 5, 2023 14:06
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 57bd09b into ethereum:master Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal e-consensus Waiting on editor consensus t-process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants