Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Bump rakefile deps #6813

Merged
merged 1 commit into from
Jun 24, 2023
Merged

CI: Bump rakefile deps #6813

merged 1 commit into from
Jun 24, 2023

Conversation

fulldecent
Copy link
Contributor

This bumps dependencies a little bit (just latest GitHub Pages gem) and fixes the build on macOS

@fulldecent fulldecent requested a review from eth-bot as a code owner April 1, 2023 19:18
@eth-bot
Copy link
Collaborator

eth-bot commented Apr 1, 2023 •
edited
Loading

File EIPS/eip-2535.md

Requires 1 more reviewers from @mudgen

@eth-bot eth-bot changed the title Bump rakefile deps Website: Bump rakefile deps Apr 1, 2023
@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Apr 1, 2023
@eth-bot eth-bot changed the title Website: Bump rakefile deps Bump rakefile deps Apr 1, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Apr 1, 2023
@eth-bot eth-bot changed the title Bump rakefile deps CI: Bump rakefile deps Apr 1, 2023
@github-actions github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels Apr 1, 2023
Pandapip1
Pandapip1 suggested changes Apr 3, 2023
View reviewed changes
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind running the GitHub pages action to make sure this still works?

@poojaranjan poojaranjan mentioned this pull request Apr 5, 2023
Closed
8 tasks
@github-actions github-actions bot added c-update Modifies an existing proposal s-final This EIP is Final t-erc labels Apr 23, 2023
@fulldecent fulldecent force-pushed the chore-bump-deps branch 3 times, most recently from 267e327 to 5144000 Compare April 23, 2023 14:06
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Apr 23, 2023
@github-actions
Copy link

The commit 1224149 (as a parent of bf2aae7) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Apr 23, 2023
@fulldecent
Copy link
Contributor Author

Hi @Pandapip1 I re-ran and the build passes.

The newer version of HTML-proofer has different options, so I matched to those. It is now more explicit about its options and in the future we can un-disable some of the checks to improve the website and SEO.

However, one of the checks was not disableable so I need to touch EIP-2535 to add image alt tags. This means the HTML-proofer check passes in CI just like it did yesterday.

If there's EIP editor approval or no complaints from @mudgen, hoping that is allowed.

Also because I touched 2535, the EIP validator attacked me about lots of modernization it wants for that PR.

Since this PR is an editorial change, not a content change, and because the scope of the PR is to fix build dependencies, I request that test failure can be ignored and EIP editors can override and merge this PR as-is.

Pandapip1
Pandapip1 approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has a well-defined scope and makes the minimum number of changes.

@fulldecent
Copy link
Contributor Author

Thank you @Pandapip1, are other reviews required to push this through?

@Pandapip1
Copy link
Member

Thank you @Pandapip1, are other reviews required to push this through?

Just any other editor. CC @SamWilsn

xinbenlv
xinbenlv approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@xinbenlv xinbenlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to updating ruby version, and LGTM if that requires new htmlproofer and also require image to be updated to support accessibility.

@poojaranjan poojaranjan mentioned this pull request Jun 14, 2023
Closed
9 tasks
@Pandapip1 Pandapip1 added this to the Manual Merge Queue milestone Jun 21, 2023
@SamWilsn SamWilsn merged commit c58533b into ethereum:master Jun 24, 2023
1 check passed
streamnft-tech pushed a commit to streamnft-tech/EIPs that referenced this pull request Oct 27, 2023
@fulldecent @ThunderDeliverer
bump dependencies (ethereum#6813)
b98d8c1 
Co-authored-by: Jan Turk <jan.turk12@gmail.com>
RaphaelHardFork pushed a commit to RaphaelHardFork/EIPs that referenced this pull request Jan 30, 2024
@fulldecent @ThunderDeliverer @RaphaelHardFork
bump dependencies (ethereum#6813)
ba7090f 
Co-authored-by: Jan Turk <jan.turk12@gmail.com>
GAEAlimited pushed a commit to GAEAlimited/EIPs that referenced this pull request Jun 19, 2024
@fulldecent @ThunderDeliverer @GAEAlimited
bump dependencies (ethereum#6813)
d9b6386 
Co-authored-by: Jan Turk <jan.turk12@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xinbenlv xinbenlv xinbenlv approved these changes

@Pandapip1 Pandapip1 Pandapip1 approved these changes

@SamWilsn SamWilsn SamWilsn approved these changes

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

@lightclient lightclient Awaiting requested review from lightclient

Assignees
No one assigned
Labels
c-update Modifies an existing proposal e-consensus Waiting on editor consensus s-final This EIP is Final t-erc w-ci Waiting on CI to pass
Projects
None yet
Milestone
Manual Merge Queue
Development

Successfully merging this pull request may close these issues.
6 participants
@fulldecent @eth-bot @Pandapip1 @xinbenlv @SamWilsn @ThunderDeliverer