Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-4881: Move to Review #6812

Merged
merged 2 commits into from
Apr 14, 2023
Merged

Conversation

ethDreamer
Copy link
Contributor

Moving 4881 to Review Stage

@ethDreamer ethDreamer requested a review from eth-bot as a code owner April 1, 2023 16:40
@github-actions github-actions bot added c-status Changes a proposal's status s-review This EIP is in Review t-interface w-ci Waiting on CI to pass labels Apr 1, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Apr 1, 2023

✅ All reviewers have approved.

@eth-bot eth-bot changed the title Move EIP-4881 to Review Update EIP-4881: Move to Review Apr 1, 2023
@eth-bot eth-bot added the e-review Waiting on editor to review label Apr 1, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Apr 1, 2023
@github-actions
Copy link

github-actions bot commented Apr 1, 2023

The commit 29e6380 (as a parent of a63de0c) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Apr 1, 2023
@poojaranjan
Copy link
Contributor

As discussed in EIP Editing Office Hour #14, the blocker for this PR to be merged is the mention of EIP-4444 in "Security consideration". However, the proposal does not seem to be depending on EIP-4444 in any way.
@ethDreamer if you'll consider re-wording that point without a specific mention of EIP-4444, EIP-4881 may be moved to the Review status.

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Apr 12, 2023
@ethDreamer
Copy link
Contributor Author

@poojaranjan

Sorry I got a bit sidetracked last week with other work but I believe I've reworded it now without references to 4444 :)

@eth-bot eth-bot enabled auto-merge (squash) April 14, 2023 16:34
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 4f3afe4 into ethereum:master Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-status Changes a proposal's status e-review Waiting on editor to review s-review This EIP is in Review t-interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants