Add EIP-5773: Multi-Resource Token standard #5773

ThunderDeliverer · 2022-10-10T21:25:11Z

This EIP draft proposal includes RMRK team's work on developing an NFT standard where a single NFT can be tied to multiple resources.

RMRK team has developed a next step in NFTs where one NFT can be tied to multiple resources.

eth-bot · 2022-10-10T21:26:09Z

All tests passed; auto-merging...

(pass) eip-5773.md

classification
`updateEIP`

passed!

(pass) assets/eip-5773/contracts/IMultiAsset.sol

classification
`ambiguous`

file assets/eip-5773/contracts/IMultiAsset.sol is associated with EIP 5773; because there are also changes being made to EIPS/eip-5773.md all changes to corresponding assets are also allowed

(pass) assets/eip-5773/contracts/MultiAssetToken.sol

classification
`ambiguous`

file assets/eip-5773/contracts/MultiAssetToken.sol is associated with EIP 5773; because there are also changes being made to EIPS/eip-5773.md all changes to corresponding assets are also allowed

(pass) assets/eip-5773/contracts/library/MultiAssetLib.sol

classification
`ambiguous`

file assets/eip-5773/contracts/library/MultiAssetLib.sol is associated with EIP 5773; because there are also changes being made to EIPS/eip-5773.md all changes to corresponding assets are also allowed

(pass) assets/eip-5773/contracts/mocks/ERC721ReceiverMock.sol

classification
`ambiguous`

file assets/eip-5773/contracts/mocks/ERC721ReceiverMock.sol is associated with EIP 5773; because there are also changes being made to EIPS/eip-5773.md all changes to corresponding assets are also allowed

(pass) assets/eip-5773/contracts/mocks/MultiAssetTokenMock.sol

classification
`ambiguous`

file assets/eip-5773/contracts/mocks/MultiAssetTokenMock.sol is associated with EIP 5773; because there are also changes being made to EIPS/eip-5773.md all changes to corresponding assets are also allowed

(pass) assets/eip-5773/contracts/mocks/NonReceiverMock.sol

classification
`ambiguous`

file assets/eip-5773/contracts/mocks/NonReceiverMock.sol is associated with EIP 5773; because there are also changes being made to EIPS/eip-5773.md all changes to corresponding assets are also allowed

(pass) assets/eip-5773/contracts/utils/MultiAssetRenderUtils.sol

classification
`ambiguous`

file assets/eip-5773/contracts/utils/MultiAssetRenderUtils.sol is associated with EIP 5773; because there are also changes being made to EIPS/eip-5773.md all changes to corresponding assets are also allowed

(pass) assets/eip-5773/hardhat.config.ts

classification
`ambiguous`

file assets/eip-5773/hardhat.config.ts is associated with EIP 5773; because there are also changes being made to EIPS/eip-5773.md all changes to corresponding assets are also allowed

(pass) assets/eip-5773/package.json

classification
`ambiguous`

file assets/eip-5773/package.json is associated with EIP 5773; because there are also changes being made to EIPS/eip-5773.md all changes to corresponding assets are also allowed

(pass) assets/eip-5773/test/multiasset.ts

classification
`ambiguous`

file assets/eip-5773/test/multiasset.ts is associated with EIP 5773; because there are also changes being made to EIPS/eip-5773.md all changes to corresponding assets are also allowed

(pass) assets/eip-5773/test/renderUtils.ts

classification
`ambiguous`

file assets/eip-5773/test/renderUtils.ts is associated with EIP 5773; because there are also changes being made to EIPS/eip-5773.md all changes to corresponding assets are also allowed

ThunderDeliverer · 2022-10-10T21:26:27Z

I intend to add discussion link at the same time as I will update the EIP number, to reduce the number of pushes to the initial PR.

xinbenlv · 2022-10-15T19:11:41Z

EIPS/eip-multi_resource_non_fungible_token_standard.md

+title: Multi-Resource Token
+description: An interface for Multi-Resource tokens.
+author: Bruno Škvorc (@Swader), Cicada (@CicadaNCR), Steven Pineda (@steven2308), Stevan Bogosavljevic (@stevyhacker), Jan Turk (@ThunderDeliverer)
+discussions-to: <URL>


Please don't forget to create a discussion thread :)

I intended to add it at the same time as the EIP number was assigned (wanted to include the EIP number in the discussion title). I'll open a discussion now and add it :)

I intended to add it at the same time as the EIP number was assigned (wanted to include the EIP number in the discussion title). I'll open a discussion now and add it :)

I thought the bot was going to assign the number and create the thread automatically.

I intended to add it at the same time as the EIP number was assigned (wanted to include the EIP number in the discussion title). I'll open a discussion now and add it :)

I thought the bot was going to assign the number and create the thread automatically.

It only reports the missing EIP number and that an editor should assign it. Should I just use the PR number? So 5773?

I'll use it as this EIP is already being referred to as EIP-5773:
https://weekinethereumnews.com/week-in-ethereum-news-october-15-2022
https://twitter.com/WeekInEthNews/status/1582456945750904832?s=20&t=0H712tazBBqHtRQgD227OA

The number can be changed at any time, if you decide to assign a different one 🤔

I thought the bot was going to assign the number and create the thread automatically.

Not yet. We're waiting on #5508.

Pandapip1

Here's my review so far.

Pandapip1 · 2022-10-23T17:29:28Z

EIPS/eip-5773.md

+
+## Abstract
+
+The Multi-Resource NFT standard allows for the construction of a new primitive: context-dependent output of multimedia information per single NFT.


WDYM by primitive?

We were referring to a simple, clearly defined, structure

Suggested change

The Multi-Resource NFT standard allows for the construction of a new primitive: context-dependent output of multimedia information per single NFT.

The Multi-Resource NFT standard allows for the construction of a new simple, clearly defined structure for context-dependent output of multimedia information per single NFT.

"Primitive" is very often associated with language features. I suggest this wording.

This makes sense. Thank you 😄

EIPS/eip-5773.md

ThunderDeliverer · 2022-10-26T09:29:39Z

Here's my review so far.

Thank you for the comments, I applied the changes based on them and pushed them

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

SamWilsn · 2022-11-01T15:11:52Z

EIPS/eip-5773.md

@@ -0,0 +1,362 @@
+---
+eip: 5773
+title: Multi-Resource Token


Probably a bit too vague. Try to expand a tiny bit about what resources are, or what you can do with these tokens while staying under the character limit.

SamWilsn · 2022-11-01T15:12:25Z

EIPS/eip-5773.md

+---
+eip: 5773
+title: Multi-Resource Token
+description: An interface for Multi-Resource tokens.


Try not to make this just a rewording of the title. It should expand a little beyond what's in the title.

EIPS/eip-5773.md

SamWilsn · 2022-11-01T15:42:42Z

EIPS/eip-5773.md

+
+RMRK MultiResource lego block and documentation
+
+- Compatible with the original version of the standard
+
+Neon Crisis, by CicadaNCR
+
+- A NFT game utilizing RMRK MultiResource lego block
+
+Snake Soldiers, by Steven Pineda
+
+- A NFT game utilizing RMRK MultiResource lego block


Please include the reference implementation in the assets directory if you have a compatible license (free to redistribute and doesn't place additional restrictions on downstream projects like Apache, MIT, or preferably CC0.)

If you cannot include them, just remove these projects.

EIPS/eip-5773.md

Applied the changes based on feedback received on the EIP Editing Office Hour Meeting ethereum#5. This commit includes changes to the proposal as well as adds an exaple implementation to assets/ directory.

EIPS/eip-5773.md

assets/eip-5773/hardhat.config.ts

assets/eip-5773/contracts/MultiResourceToken.sol

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>

assets/eip-5773/contracts/IMultiResource.sol

The proposal was renamed to Context-Dependent Multi-Asset Tokens to better illustrate its function. Another example was added to represent the possible IoT usecase and the explanation on the naming decision was added to the rationale. The examples were relicensed to CC0, to conform to the requirements of EIP repository.

assets/eip-5773/contracts/MultiAssetToken.sol

assets/eip-5773/contracts/IMultiAsset.sol

assets/eip-5773/contracts/library/MultiAssetLib.sol

assets/eip-5773/contracts/mocks/ERC721ReceiverMock.sol

assets/eip-5773/contracts/mocks/MultiAssetTokenMock.sol

assets/eip-5773/contracts/mocks/NonReceiverMock.sol

EIPS/eip-5773.md

assets/eip-5773/contracts/utils/MultiAssetRenderUtils.sol

a privitive is generally a building block, and isn't necessarily limited to programming languages

Propose Multi-Resource Token standard

ee0025a

RMRK team has developed a next step in NFTs where one NFT can be tied to multiple resources.

ThunderDeliverer requested a review from eth-bot as a code owner October 10, 2022 21:25

ThunderDeliverer added 3 commits October 10, 2022 23:35

Address issues reported by EIP repository's CI

758ecdc

Fix styling discrepancies in section titles

e3a880b

Address CI's issues in the preabmle

365eb1c

github-actions bot added c-new Creates a brand new proposal e-number Waiting on EIP Number assignment s-draft This EIP is a Draft t-erc labels Oct 10, 2022

xinbenlv reviewed Oct 15, 2022

View reviewed changes

ThunderDeliverer added 2 commits October 15, 2022 21:46

Add discussion URL

69b2ffd

Fix discussion URL formatting

08c0038

ThunderDeliverer requested a review from xinbenlv October 15, 2022 19:50

poojaranjan mentioned this pull request Oct 18, 2022

EIP Editing Office Hour Meeting 4 ethcatherders/EIPIP#183

Closed

Add the EIP number

f192cbc

github-actions bot removed the e-number Waiting on EIP Number assignment label Oct 18, 2022

Fix getResourceMeta specification

d8622f5

Pandapip1 changed the title ~~Propose Multi-Resource Token standard~~ Add EIP-5773: Multi-Resource Token standard Oct 23, 2022

Pandapip1 previously requested changes Oct 23, 2022

View reviewed changes

Apply changes based on PR comments

897561a

Replace "primitive" with a clearer explanation

674cf11

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

poojaranjan mentioned this pull request Nov 1, 2022

EIP Editing Office Hour Meeting 5 ethcatherders/EIPIP#186

Closed

SamWilsn reviewed Nov 1, 2022

View reviewed changes

poojaranjan mentioned this pull request Nov 11, 2022

EIP Editing Office Hour Meeting 6 ethcatherders/EIPIP#188

Closed

Apply changes based on ECH call ethereum#5

e2bee24

Applied the changes based on feedback received on the EIP Editing Office Hour Meeting ethereum#5. This commit includes changes to the proposal as well as adds an exaple implementation to assets/ directory.

ThunderDeliverer requested review from Pandapip1 and removed request for xinbenlv November 15, 2022 13:37

ThunderDeliverer requested review from SamWilsn and Pandapip1 and removed request for Pandapip1 and SamWilsn November 15, 2022 13:37

ThunderDeliverer added 3 commits November 15, 2022 14:41

Address the stylistic issues reported by the CI

fabcd1b

Fix a reference to EIP-712

67718ce

Minor typo fixes

a9543d8

SamWilsn reviewed Nov 15, 2022

View reviewed changes

EIPS/eip-5773.md Outdated Show resolved Hide resolved

EIPS/eip-5773.md Outdated Show resolved Hide resolved

assets/eip-5773/hardhat.config.ts Outdated Show resolved Hide resolved

assets/eip-5773/contracts/MultiResourceToken.sol Outdated Show resolved Hide resolved

Updates getResourceMetadata description

1eecc07

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>

Pandapip1 reviewed Nov 16, 2022

View reviewed changes

assets/eip-5773/contracts/IMultiResource.sol Outdated Show resolved Hide resolved

ThunderDeliverer requested a review from SamWilsn November 16, 2022 23:13

SamWilsn reviewed Nov 18, 2022

View reviewed changes

ThunderDeliverer added 5 commits November 18, 2022 23:11

Fix license identifier & Specification contract title

0530684

Fix indexes of Rationale questions

b2d3efa

Minor polishing of the rationale

b0f75d9

Update references to assets to use an istead of a in Rationale

3d6c7ec

Final polishes

554ceed

SamWilsn approved these changes Nov 25, 2022

View reviewed changes

eth-bot enabled auto-merge (squash) November 25, 2022 20:57

eth-bot approved these changes Nov 25, 2022

View reviewed changes

eth-bot merged commit a3bcb50 into ethereum:master Nov 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add EIP-5773: Multi-Resource Token standard #5773

Add EIP-5773: Multi-Resource Token standard #5773

ThunderDeliverer commented Oct 10, 2022

eth-bot commented Oct 10, 2022 •

edited

Loading

ThunderDeliverer commented Oct 10, 2022 •

edited

Loading

xinbenlv Oct 15, 2022

ThunderDeliverer Oct 15, 2022

ThunderDeliverer Oct 15, 2022

gcolvin Oct 16, 2022

ThunderDeliverer Oct 16, 2022

ThunderDeliverer Oct 18, 2022

Pandapip1 Oct 20, 2022

Pandapip1 left a comment

Pandapip1 Oct 23, 2022

ThunderDeliverer Oct 26, 2022

Pandapip1 Oct 27, 2022

ThunderDeliverer Oct 27, 2022

ThunderDeliverer commented Oct 26, 2022

SamWilsn Nov 1, 2022

SamWilsn Nov 1, 2022

SamWilsn Nov 1, 2022


		## Abstract

		The Multi-Resource NFT standard allows for the construction of a new primitive: context-dependent output of multimedia information per single NFT.

Add EIP-5773: Multi-Resource Token standard #5773

Add EIP-5773: Multi-Resource Token standard #5773

Conversation

ThunderDeliverer commented Oct 10, 2022

eth-bot commented Oct 10, 2022 • edited Loading

All tests passed; auto-merging...

(pass) eip-5773.md

(pass) assets/eip-5773/contracts/IMultiAsset.sol

(pass) assets/eip-5773/contracts/MultiAssetToken.sol

(pass) assets/eip-5773/contracts/library/MultiAssetLib.sol

(pass) assets/eip-5773/contracts/mocks/ERC721ReceiverMock.sol

(pass) assets/eip-5773/contracts/mocks/MultiAssetTokenMock.sol

(pass) assets/eip-5773/contracts/mocks/NonReceiverMock.sol

(pass) assets/eip-5773/contracts/utils/MultiAssetRenderUtils.sol

(pass) assets/eip-5773/hardhat.config.ts

(pass) assets/eip-5773/package.json

(pass) assets/eip-5773/test/multiasset.ts

(pass) assets/eip-5773/test/renderUtils.ts

ThunderDeliverer commented Oct 10, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Pandapip1 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ThunderDeliverer commented Oct 26, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eth-bot commented Oct 10, 2022 •

edited

Loading

ThunderDeliverer commented Oct 10, 2022 •

edited

Loading