Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-1: Fix Backward Compatibility Typos #5680

Closed
wants to merge 4 commits into from

Conversation

Pandapip1
Copy link
Member

This has been bugging me for a while. Thoughts?

@Pandapip1 Pandapip1 added the e-consensus Waiting on editor consensus label Sep 18, 2022
@github-actions github-actions bot added c-update Modifies an existing proposal t-process labels Sep 18, 2022
@github-actions github-actions bot added e-number Waiting on EIP Number assignment s-draft This EIP is a Draft labels Sep 18, 2022
@eth-bot
Copy link
Collaborator

eth-bot commented Sep 18, 2022

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):


(fail) eip-1.md

classification
updateEIP

(fail) eip-template.md

classification
ambiguous
  • 'eip-template.md' must be in eip-###.md format; this error will be overwritten upon relevant editor approval

@Pandapip1 Pandapip1 changed the title Update EIP-1: Fix Backward Compatibility Typo Update EIP-1: Fix Backward Compatibility Typos Sep 18, 2022
xinbenlv
xinbenlv previously approved these changes Sep 19, 2022
@Pandapip1 Pandapip1 requested review from SamWilsn, axic, lightclient and a team and removed request for a team September 20, 2022 00:05
@SamWilsn
Copy link
Contributor

I think they're both acceptable, and prefer the option that doesn't require changing eipw 🤣

@Pandapip1
Copy link
Member Author

I think they're both acceptable, and prefer the option that doesn't require changing eipw 🤣

Should we add a [sic] then?

Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this is the more accepted form, both are technically correct. I think that it's best to leave as-is so that we don't need to change 5000+ EIPs and eipw.

@Pandapip1
Copy link
Member Author

both are technically correct

Every spell checker I've used disagrees.

I can change the 5000+ files if need be. I think we can also just keep the old files as having the old form until they are changed. I volunteer to try to fix eipw.

@xinbenlv
Copy link
Contributor

I am ok ether way. I just hope it be consistent across the board....

@Pandapip1
Copy link
Member Author

Although this is the more accepted form, both are technically correct. I think that it's best to leave as-is so that we don't need to change 5000+ EIPs and eipw.

There are <1000 EIPs, and it's possible to automate this in a few minutes (see my change with the LICENSE file)

@lightclient
Copy link
Member

@SamWilsn and I have both expressed that we do not want to pursue this change.

@Pandapip1 Pandapip1 deleted the Pandapip1-backward-compatibility-eip1 branch November 13, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal e-consensus Waiting on editor consensus e-number Waiting on EIP Number assignment s-draft This EIP is a Draft t-process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants