Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration: Add "furter" to whitelist #5586

Merged
merged 2 commits into from
Sep 7, 2022
Merged

Configuration: Add "furter" to whitelist #5586

merged 2 commits into from
Sep 7, 2022

Conversation

Pandapip1
Copy link
Member

@Pandapip1 Pandapip1 commented Sep 3, 2022

Add someone else's name to CodeSpell

@Pandapip1 Pandapip1 requested a review from eth-bot as a code owner September 3, 2022 22:42
@Pandapip1 Pandapip1 added this to the Manual Merge Queue milestone Sep 3, 2022
@eth-bot
Copy link
Collaborator

eth-bot commented Sep 3, 2022

A critical exception has occurred:
Message: pr 5586 is already merged; quitting
(cc @alita-moore, @mryalamanchi)

@Pandapip1 Pandapip1 changed the title Configuration: Add "complies" to whitelist Configuration: Add "furter" to whitelist Sep 3, 2022
Copy link
Contributor

@xinbenlv xinbenlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for this change.
If I may suggest, consider just exclude the author names instead.

@Pandapip1
Copy link
Member Author

If I may suggest, consider just exclude the author names instead.

This has already been suggested. Sadly, this is not possible.

@xinbenlv
Copy link
Contributor

xinbenlv commented Sep 5, 2022

I think it can be archived by markdown linter plus suppress marker markdownlint-disable ish, have we considered look into it?

@Pandapip1
Copy link
Member Author

Markdownlint doesn't check spelling. This is the current situation.

Admittedly, I have added a bypass so that codespell doesn't actually error right now, so finding a fix is not top priority.

@eth-bot eth-bot enabled auto-merge (squash) September 7, 2022 14:27
@eth-bot eth-bot merged commit d90ca2b into master Sep 7, 2022
@eth-bot eth-bot deleted the Pandapip1-patch-2 branch September 7, 2022 14:27
nachomazzara pushed a commit to nachomazzara/EIPs that referenced this pull request Jan 13, 2023
* Configuration: Add "complies" to whitelist

* Change to furter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants