Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP-5573: SIWE ReCap Extension #5573
Add EIP-5573: SIWE ReCap Extension #5573
Changes from 56 commits
0b92401
183f0f7
1ff774d
34cd30b
50c31e3
954042b
6391f26
612d298
83a55cc
91e8426
07fa273
c676e3c
899d304
5512c3c
fbb6016
e1e07ec
703810e
57f1263
1e46c4d
bc0b8f9
aa7a575
a8e9382
6dd1632
b798087
d7b23bf
6d1fdf5
3e5b2cb
9bff76e
9aa00c1
a18d19a
f656e9d
b3248b6
5c4575d
ac142ae
562b97c
c4301a0
ebc55b5
bf2aaea
8d16144
1472cd4
dc94c15
3ffc8c1
fcf4798
42f1972
54a2ec5
a9db008
157eaff
de369d6
6d8c0f6
4719e6b
0d4f4fe
141ffec
0fb7318
65d4737
19fb396
ddd4d20
4157080
cbfe7e5
b9f370d
f0bcaf9
77426c0
10019f8
d666493
44e743a
7acb670
e16f664
94c84ad
86805fc
7e918ca
21ee39c
08f7244
3b4801a
6557d2a
19dae81
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It isn't common to announce the different audiences of an EIP unless there are different sections for them. I'd recommend just omitting this section (or, alternatively, giving them each a section on stuff they need to implement.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So both the proposal and messages complying with this standard are
GapGroks
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would propose the following breakdown for clarity:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd maybe rename that section "CapGrok Syntax" because you've already defined that a CapGrok is a Capability expression syntax?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your Rationale is describing why the EIP as a whole should exist. This type of content belongs in the Motivation section.
The Rationale is meant to describe individual technical choices in the EIP itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, I moved it and I will provide contents for the Rationale section later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As someone not familiar with authentication systems, I find the first sentence unnerving. Would you mind expanding it a bit, and perhaps explain mitigations or provide examples of what "require to authenticate the delegee in addition" means?