Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-1: Add finalized date to the preamble #5517

Closed
wants to merge 8 commits into from
Closed

Update EIP-1: Add finalized date to the preamble #5517

wants to merge 8 commits into from

Conversation

xinbenlv
Copy link
Contributor

Fixes #5488

@xinbenlv xinbenlv requested a review from eth-bot as a code owner August 21, 2022 17:44
@eth-bot
Copy link
Collaborator

eth-bot commented Aug 21, 2022 •
edited
Loading

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

(fail) eip-1.md

classification
updateEIP

(fail) eip-template.md

classification
ambiguous
  • 'eip-template.md' must be in eip-###.md format; this error will be overwritten upon relevant editor approval

Pandapip1
Pandapip1 previously approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xinbenlv
Copy link
Contributor Author

Can this be merged?

SamWilsn
SamWilsn previously requested changes Aug 22, 2022
View reviewed changes
EIPS/eip-1.md Outdated Show resolved Hide resolved
eip-template.md Outdated Show resolved Hide resolved
@xinbenlv xinbenlv dismissed stale reviews from Pandapip1 and ghost via fb0ceab August 22, 2022 16:10
xinbenlv and others added 3 commits August 22, 2022 12:10
@xinbenlv @SamWilsn
Update eip-template.md
fb0ceab 
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
@xinbenlv @SamWilsn
Update EIPS/eip-1.md
13ef95d 
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
@xinbenlv
Update eip-1.md
991f5b5
@xinbenlv
Copy link
Contributor Author

@SamWilsn thanks for comment. Updated, please review again.

SamWilsn
SamWilsn reviewed Aug 22, 2022
View reviewed changes
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SamWilsn SamWilsn self-requested a review August 22, 2022 16:58
@xinbenlv
Copy link
Contributor Author

@SamWilsn can you re-approve

@lightclient
Copy link
Member

I disagree with this PR.

@xinbenlv
Copy link
Contributor Author

@lightclient any concern /revise suggestions?

@lightclient
Copy link
Member

I posted in #5488

SamWilsn
SamWilsn previously approved these changes Aug 24, 2022
View reviewed changes
@SamWilsn SamWilsn dismissed their stale review August 24, 2022 15:19

Didn't realize @lightclient had objected.

@Pandapip1 Pandapip1 changed the title Add finalized date to the preamble Update EIP-1: Add finalized date to the preamble Aug 28, 2022
@github-actions github-actions bot added c-update Modifies an existing proposal e-number Waiting on EIP Number assignment s-draft This EIP is a Draft t-process labels Aug 28, 2022
@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added w-stale Waiting on activity and removed w-stale Waiting on activity labels Sep 14, 2022
@Pandapip1 Pandapip1 added the e-consensus Waiting on editor consensus label Sep 15, 2022
@SamWilsn SamWilsn mentioned this pull request Sep 30, 2022
Closed
10 tasks
@xinbenlv
Copy link
Contributor Author

xinbenlv commented Oct 5, 2022 •
edited
Loading

Per discussion on today's EIPIP Meeting 66 with @lightclient @SamWilsn @poojaranjan , we are putting on hold this PR in favor of having a new PR(#5755) that adds a upgrade blocknum or upgrade name for Core EIP and then revisit the necessity for having a finalized date.

@xinbenlv
Copy link
Contributor Author

Closing for now until we get new interest in adding a finalized date

@xinbenlv xinbenlv closed this Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pandapip1 Pandapip1 Pandapip1 approved these changes

@SamWilsn SamWilsn SamWilsn left review comments

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

Assignees
No one assigned
Labels
c-update Modifies an existing proposal e-consensus Waiting on editor consensus e-number Waiting on EIP Number assignment s-draft This EIP is a Draft t-process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add finalized date to EIPs.
5 participants
@xinbenlv @eth-bot @lightclient @Pandapip1 @SamWilsn