Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Change Stale Thresholds" #5397

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

MicahZoltu
Copy link
Contributor

Reverts #5360

cc @Pandapip1 I'm reverting this, even though I think it is a good change, in an effort to disincentivize editors from merging changes to the process without getting approval from any other editors or waiting a sufficient amount of time for review. This isn't the first time someone has merged without acquiring approval/waiting, and I want to make sure that it is clear to everyone that just merging anyway and saying "oops"/"sorry" afterward isn't a viable strategy for forcing changes through.

@eth-bot eth-bot enabled auto-merge (squash) August 3, 2022 04:19
@eth-bot
Copy link
Collaborator

eth-bot commented Aug 3, 2022

All tests passed; auto-merging...

(pass) .github/workflows/stale.yml

classification
ambiguous
  • file .github/workflows/stale.yml is not a valid filename, but this error has been ignored due to editor approvals

@MicahZoltu MicahZoltu disabled auto-merge August 3, 2022 04:21
@MicahZoltu MicahZoltu merged commit 1ae8d3b into master Aug 3, 2022
@MicahZoltu MicahZoltu deleted the revert-5360-change-stale-threshold branch August 3, 2022 04:21
nachomazzara pushed a commit to nachomazzara/EIPs that referenced this pull request Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants