Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise EIP-2535 #5120

Closed
wants to merge 11 commits into from
Closed

Revise EIP-2535 #5120

wants to merge 11 commits into from

Conversation

Pandapip1
Copy link
Member

@Pandapip1 Pandapip1 commented Jun 1, 2022

CC: @mudgen

@eth-bot
Copy link
Collaborator

eth-bot commented Jun 1, 2022

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):


(fail) eip-2535.md

classification
updateEIP
  • eip-2535.md requires approval from one of (@mudgen)

@ethereum ethereum deleted a comment Jun 4, 2022
@ethereum ethereum deleted a comment Jun 4, 2022
Copy link
Contributor

@MicahZoltu MicahZoltu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should get this to align with latest template before merging. Remove Simple Summary, add description header field, correct sections to match EIP sections, remove external links, etc.

At the moment, this doesn't look much like an EIP at all, and I actually recommend moving it back to Review as it will need a lot of work to bring it in line with our repository standards.

@Pandapip1 Pandapip1 changed the title Finalize EIP-2535 Move EIP-2535 to Review Jun 4, 2022
Copy link
Contributor

@MicahZoltu MicahZoltu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why I approved this. 😬 This still doesn't follow the template at all. Lots of sections that aren't part of the templated sections for example. Also the comment above about order of metadata fields needs to be fixed.

EIPS/eip-2535.md Outdated Show resolved Hide resolved
EIPS/eip-2535.md Outdated Show resolved Hide resolved
EIPS/eip-2535.md Outdated Show resolved Hide resolved
EIPS/eip-2535.md Outdated Show resolved Hide resolved
I am not done editing this, but I'll commit the changes for now
@Pandapip1 Pandapip1 changed the title Move EIP-2535 to Review Revise EIP-2535 Jun 8, 2022
Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good overall, just a few nits.

EIPS/eip-2535.md Outdated Show resolved Hide resolved
EIPS/eip-2535.md Outdated Show resolved Hide resolved
EIPS/eip-2535.md Outdated Show resolved Hide resolved
EIPS/eip-2535.md Outdated Show resolved Hide resolved
EIPS/eip-2535.md Outdated Show resolved Hide resolved
EIPS/eip-2535.md Outdated Show resolved Hide resolved
Pandapip1 and others added 2 commits June 16, 2022 07:32
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
@eip-automerger
Copy link

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

  • Trying to change EIP 2535 state from Last Call to Review
  • EIP 2535 requires approval from one of (@mudgen)

@Pandapip1
Copy link
Member Author

Pandapip1 commented Jun 16, 2022

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

Trying to change EIP 2535 state from Last Call to Review
EIP 2535 requires approval from one of (@mudgen)

Is @eip-automerger the new @eth-bot?

@Pandapip1
Copy link
Member Author

Pandapip1 commented Jun 16, 2022

@mudgen Please note that I have removed a lot of content from this. This is primarily so that this PR can be merged, but feel free to re-add things like the spec for Diamond Storage & App Storage.

I might also consider adding myself as an author. LMK if that's okay!

Finally, I also feel like the spec could be tighter overall. I would recommend bundling up many of the conventions and making them extensions. Notably, I would also like if the names were more strict, to aid with interfacing. This is outside of the scope of this PR, though.

@Pandapip1 Pandapip1 marked this pull request as ready for review June 16, 2022 14:43
@mudgen
Copy link
Contributor

mudgen commented Jun 16, 2022

@Pandapip1 I appreciate your help but I don't want to make a lot of the changes in this pull request. I do not want to rewrite or remove what is already written. But I do want changed some of the header names and other smaller changes to make it more compliant with the EIP template.

@MicahZoltu
Copy link
Contributor

Is this the new @eth-bot?

Depends on what you mean by "new". 😀 It is the auto-merge bot letting you know what needs to change in order to merge this PR.

@Pandapip1
Copy link
Member Author

I'll let @mudgen do this.

@Pandapip1 Pandapip1 closed this Jul 11, 2022
@Pandapip1 Pandapip1 deleted the patch-4 branch July 11, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants