EIP-1: Mark sections that are optional as optional (closes #5112) #5118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All tests passed; auto-merging...(pass) eip-1.md
|
Pandapip1
reviewed
May 31, 2022
MicahZoltu
reviewed
Jun 1, 2022
There was a problem hiding this comment.
Basically one comment, which is that we should remove the subjectivity from this. While I do think that editors should encourage authors to include these sections when it makes sense, I would prefer that the author has the final say in their presence. The exception is backward compatibility, where I feel like an editor can objectively assert whether or not there is a backward incompatibility that needs to be mentioned or not.
Co-authored-by: Micah Zoltu <micah@zoltu.net> Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Pandapip1
reviewed
Jun 1, 2022
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
|
I think that was all outstanding comments on this PR. |
|
Looks good to me. If no one objects in the next week, I say we merge it. |
nachomazzara
pushed a commit
to nachomazzara/EIPs
that referenced
this pull request
Jan 13, 2023
) (ethereum#5118) * Mark sections that are optional as optional (closes ethereum#5112) * Apply suggestions from code review Co-authored-by: Micah Zoltu <micah@zoltu.net> Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-1.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * s/severity/consequences Co-authored-by: Micah Zoltu <micah@zoltu.net> Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.