EIP-4844: Change to versioned hashes #5106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the validate_blob_transaction_wrapper function, it uses blob_commmitments which doesn't make sense. It makes more sense when it uses blob_versioned_hashes instead.
All tests passed; auto-merging...(pass) eip-4844.md
|
|
Looks good to me! Thanks! |
|
Looks good to me! Thanks! |
asn-d6
approved these changes
May 26, 2022
nachomazzara
pushed a commit
to nachomazzara/EIPs
that referenced
this pull request
Jan 13, 2023
In the validate_blob_transaction_wrapper function, it uses blob_commmitments which doesn't make sense. It makes more sense when it uses blob_versioned_hashes instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
validate_blob_transaction_wrapperfunction, it usesblob_commmitmentswhich doesn't make sense. It makes more sense when it usesblob_versioned_hashesinstead.