reference EIP-2470 (create2 deployer) #4344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All tests passed; auto-merging... |
MicahZoltu
reviewed
Oct 4, 2021
| @@ -303,7 +303,8 @@ The paymaster scheme allows a contract to passively pay on users' behalf under a | |||
|
|
|||
| It is an important design goal of this proposal to replicate the key property of EOAs that users do not need to perform some custom action or rely on an existing user to create their wallet; they can simply generate an address locally and immediately start accepting funds. | |||
|
|
|||
| This is accomplished by having the entry point itself create wallets using CREATE2. The `UserOperation` struct has an `initCode` field; this field would be empty for all operations by a given wallet after the first, but the first operation would fill in the `initCode`. The entry point creates the wallet, and then performs the operation. The user can compute the address of their wallet by locally running the [EIP 1014](https://eips.ethereum.org/EIPS/eip-1014) CREATE2 address formula. The salt used is the `nonce` of the `UserOperation`. | |||
| This is accomplished by having the entry point itself create wallets using CREATE2. The `UserOperation` struct has an `initCode` field; this field would be empty for all operations by a given wallet after the first, but the first operation would fill in the `initCode`. The entry point uses [EIP-2470](https://eips.ethereum.org/EIPS/eip-2470) deployer contract to create the wallet, and then performs the operation. The user can compute the address of their wallet by locally running the [EIP 1014](https://eips.ethereum.org/EIPS/eip-1014) CREATE2 address formula. The salt used is the `nonce` of the `UserOperation`. | |||
There was a problem hiding this comment.
Suggested change
| This is accomplished by having the entry point itself create wallets using CREATE2. The `UserOperation` struct has an `initCode` field; this field would be empty for all operations by a given wallet after the first, but the first operation would fill in the `initCode`. The entry point uses [EIP-2470](https://eips.ethereum.org/EIPS/eip-2470) deployer contract to create the wallet, and then performs the operation. The user can compute the address of their wallet by locally running the [EIP 1014](https://eips.ethereum.org/EIPS/eip-1014) CREATE2 address formula. The salt used is the `nonce` of the `UserOperation`. | |
| This is accomplished by having the entrypoint itself create wallets using CREATE2. The `UserOperation` struct has an `initCode` field; this field would be empty for all operations by a given wallet after the first, but the first operation would fill in the `initCode`. The entry point uses [EIP-2470](./eip-2470.md) deployer contract to create the wallet, and then performs the operation. The user can compute the address of their wallet by locally running the [EIP 1014](./eip-1014.md) `CREATE2` address formula. The salt used is the `nonce` of the `UserOperation`. |
|
|
BIS CBDC incoming…
On Mon, 4 Oct 2021 at 04:05, Micah Zoltu ***@***.***> wrote:
eip-4337.md: trailing whitespace
- internal image ../assets/eip-4337/image1.png does not exist (line
279)
- internal image ../assets/eip-4337/image2.png does not exist (line
293)
- linking to internal hash
#Reputation-scoring-and-throttlingbanning-for-paymasters that does not
exist (line 299)
reputation, throttling and banning section
<#m_8504404199559377653_Reputation-scoring-and-throttlingbanning-for-paymasters>
- linking to internal hash #Simulation that does not exist (line 281)
Simulation section below <#m_8504404199559377653_Simulation>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4344 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALPDOQFBV5M223WSMS6PUDUFEKXDANCNFSM5FH6OXGA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
Sent from iPhone
|
|
@vbuterin This shouldn't have been merged. It wasn't passing CI, which is why it didn't auto-merge. This can cause CI to fail for every PR from now on until someone goes and fixes the failing CI issues. |
|
Though, I suppose this hasn't been passing CI since it was created, not because of this PR specifically. Someone really should fix this EIP so it passes CI ASAP. |
|
Ah, my bad. This PR was against your branch, which hasn't been merged to master yet! Everything is fine, please ignore my previous comments. 😬 |
MicahZoltu
added a commit
that referenced
this pull request
Oct 8, 2021
* Account Abstraction via Entry Point Contract specification An account abstraction proposal which completely avoids the need for consensus-layer protocol changes, instead relying on a separate mempool of `UserOperation` objects and miners either running custom code or connecting to a bundle marketplace. * Rename file to match ERC number * Update eip-4337.md * Apply suggestions from code review Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> * Replaced simple summary with abstract * Apply suggestions from code review * Changing to relative links for images * Update EIPS/eip-4337.md * Added mandatory sections * reference EIP-2470 (create2 deployer) (#4344) * Made EIP links relative * Update EIPS/eip-4337.md Co-authored-by: Micah Zoltu <micah@zoltu.net> * Update EIPS/eip-4337.md Co-authored-by: Micah Zoltu <micah@zoltu.net> * Update EIPS/eip-4337.md * Update EIPS/eip-4337.md * Update EIPS/eip-4337.md * add images for eip-4337 Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> Co-authored-by: Dror Tirosh <dror@opengsn.org> Co-authored-by: Micah Zoltu <micah@zoltu.net> Co-authored-by: lightclient@protonmail.com <lightclient@protonmail.com>
PhABC
pushed a commit
to PhABC/EIPs
that referenced
this pull request
Jan 25, 2022
…reum#4337) * Account Abstraction via Entry Point Contract specification An account abstraction proposal which completely avoids the need for consensus-layer protocol changes, instead relying on a separate mempool of `UserOperation` objects and miners either running custom code or connecting to a bundle marketplace. * Rename file to match ERC number * Update eip-4337.md * Apply suggestions from code review Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> * Replaced simple summary with abstract * Apply suggestions from code review * Changing to relative links for images * Update EIPS/eip-4337.md * Added mandatory sections * reference EIP-2470 (create2 deployer) (ethereum#4344) * Made EIP links relative * Update EIPS/eip-4337.md Co-authored-by: Micah Zoltu <micah@zoltu.net> * Update EIPS/eip-4337.md Co-authored-by: Micah Zoltu <micah@zoltu.net> * Update EIPS/eip-4337.md * Update EIPS/eip-4337.md * Update EIPS/eip-4337.md * add images for eip-4337 Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> Co-authored-by: Dror Tirosh <dror@opengsn.org> Co-authored-by: Micah Zoltu <micah@zoltu.net> Co-authored-by: lightclient@protonmail.com <lightclient@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vbuterin ,
this PR adds the create2 deployer refernce to the EIP
the code is updated in eth-infinitism/account-abstraction#14
(can't PR to the EIP-4337 itself, since it is not public,