[DRAFT] EIP-3978: Introduce gas refunds on reverts #3978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k06a
changed the title
|
All tests passed; auto-merging... |
auto-merge was automatically disabled
September 16, 2021 16:31
Head branch was pushed to by a user without write access
k06a
force-pushed
the
gas-refund-on-reverts
branch
from
d5ca1d1 to
a3efac8
Compare
lightclient
previously requested changes
Sep 16, 2021
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
auto-merge was automatically disabled
September 16, 2021 18:38
Head branch was pushed to by a user without write access
…into gas-refund-on-reverts # Conflicts: # EIPS/eip-3978.md
auto-merge was automatically disabled
September 16, 2021 18:46
Head branch was pushed to by a user without write access
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
auto-merge was automatically disabled
September 16, 2021 20:13
Head branch was pushed to by a user without write access
…into gas-refund-on-reverts
auto-merge was automatically disabled
September 16, 2021 20:16
Head branch was pushed to by a user without write access
MicahZoltu
suggested changes
Sep 17, 2021
|
|
||
| ## Specification | ||
|
|
||
| Let's count all SSTORE gas costs within every subcall, excluding access costs. And on reverting any subcall let's not erase refund counter, but: |
There was a problem hiding this comment.
This needs to be much more clearly specified, and it needs to be phrased as an assertion not a suggestion (don't use terms like "let's" as it comes off as a suggestion rather than an assertion. EIPs should be technical specifications that assert how things MUST behave.
There was a problem hiding this comment.
Thanks, this makes sense.
Co-authored-by: Micah Zoltu <micah@zoltu.net>
auto-merge was automatically disabled
September 24, 2021 10:09
Head branch was pushed to by a user without write access
Co-authored-by: Micah Zoltu <micah@zoltu.net>
auto-merge was automatically disabled
September 24, 2021 10:10
Head branch was pushed to by a user without write access
MicahZoltu
approved these changes
Sep 24, 2021
PhABC
pushed a commit
to PhABC/EIPs
that referenced
this pull request
Jan 25, 2022
* Introduce gas refunds on reverts * Update EIPS/eip-3978.md Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> * Fixes * Update EIPS/eip-3978.md Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> * Fix narrative * Update EIPS/eip-3978.md Co-authored-by: Micah Zoltu <micah@zoltu.net> * Update EIPS/eip-3978.md Co-authored-by: Micah Zoltu <micah@zoltu.net> Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> Co-authored-by: Micah Zoltu <micah@zoltu.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's discuss here: https://ethereum-magicians.org/t/eip-3978-gas-refunds-on-reverts/7071