1559: Removes unnecessary max #3640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can prove that the `parent_base_fee_per_gas - base_fee_per_gas_delta > 0`, so flooring to 0 is unnecessary.
MicahZoltu
commented
Jul 5, 2021
| expected_base_fee_per_gas = max(parent_base_fee_per_gas - base_fee_per_gas_delta, 0) | ||
| expected_base_fee_per_gas = parent_base_fee_per_gas - base_fee_per_gas_delta |
There was a problem hiding this comment.
(parent_gas_target - parent_gas_used) / parent_gas_targetis always between 0 and 1 sinceparent_gas_used < parent_gas_targetin this code path and both numbers are always positive.- This means that
base_fee_per_gas_deltawill be between0/8andparent_base_fee_per_gas/8in this code path. - Which means
base_fee_per_gas_deltawill always be greater than or equal to 0.
|
@MicahZoltu @lightclient looks like the bot is also expecting author review, does editor review override lack of author in this case? |
|
@alita-moore no, I was just approving to share my opinion. It's up to the authors to merge. |
|
Ping @MicahZoltu. |
auto-merge was automatically disabled
July 28, 2021 06:34
Pull request was closed
PhABC
pushed a commit
to PhABC/EIPs
that referenced
this pull request
Jan 25, 2022
We can prove that the `parent_base_fee_per_gas - base_fee_per_gas_delta > 0`, so flooring to 0 is unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can prove that the
parent_base_fee_per_gas - base_fee_per_gas_delta > 0, so flooring to 0 is unnecessary.