Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create EIP for frame-pointer-relative memory addressing #3337

Merged
merged 7 commits into from
Mar 6, 2021

Conversation

Arachnid
Copy link
Contributor

@Arachnid Arachnid commented Mar 6, 2021

No description provided.

Copy link
Contributor

@MicahZoltu MicahZoltu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the frontmatter change is required to merge as draft.

EIPS/eip-3337.md Outdated
type: Standards Track
category: Core
created: 2021-03-06
requires: <EIP number(s)>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
requires: <EIP number(s)>

EIPS/eip-3337.md Outdated Show resolved Hide resolved
EIPS/eip-3337.md Outdated Show resolved Hide resolved
EIPS/eip-3337.md Outdated Show resolved Hide resolved
Arachnid and others added 4 commits March 7, 2021 08:51
Co-authored-by: Micah Zoltu <micah@zoltu.net>
Co-authored-by: Micah Zoltu <micah@zoltu.net>
Co-authored-by: Micah Zoltu <micah@zoltu.net>
@Arachnid
Copy link
Contributor Author

Arachnid commented Mar 6, 2021

@MicahZoltu PTAL

@MicahZoltu MicahZoltu closed this Mar 6, 2021
@MicahZoltu MicahZoltu reopened this Mar 6, 2021
@MicahZoltu MicahZoltu merged commit 4df996c into ethereum:master Mar 6, 2021
For blocks where `block.number >= FORK_BLOCK`, the following changes apply.

### Frame pointer
A new EVM internal state variable called the "frame pointer" is introduced. This is a signed integer that starts at 0.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably needs to be specified as 256-bit twos-complement for the sake of the GETFP and SETFP operations.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to bring this up in the discussions-to to make sure it gets seen. I agree that this needs more specificity!

Side note: We probably don't need 256-bits, likely 32-bits would be way more than enough?

phi-line pushed a commit to phi-line/EIPs that referenced this pull request Apr 29, 2021
Introduces four new opcodes for loading data from and storing data to memory offset by a frame pointer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants