Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling mistakes detected by newer codespell #2683

Merged
merged 4 commits into from
Jun 2, 2020

Conversation

axic
Copy link
Member

@axic axic commented May 30, 2020

Fixes #2674.

@eip-automerger
Copy link

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

@axic
Copy link
Member Author

axic commented Jun 1, 2020

This is needed to bring master back to operational state.

@nicksavers @Arachnid @Souptacular @gcolvin anyone wants to approve/merge?

@rekmarks
Copy link
Contributor

rekmarks commented Jun 1, 2020

As an author of 1193, I want to second @axic's call for merging this. We're at the end of our review period and need to get a final set of changes merged ASAP.

@Arachnid Arachnid merged commit 4caaba2 into ethereum:master Jun 2, 2020
@Arachnid
Copy link
Contributor

Arachnid commented Jun 2, 2020

Can we please disable spellcheck as a required part of the build? It's absurd that a spelling error in one EIP can break the whole build - and since spell checkers have false positives, it shouldn't be required.

@axic axic deleted the spell branch June 2, 2020 23:51
@rekmarks
Copy link
Contributor

rekmarks commented Jun 3, 2020

I'll chime in to say that the codespell check seems fine to me on paper so long as it doesn't prevent the repo from functioning normally. I'd be willing to help write docs for contributors on how to deal with it, but I'm not sure where to put them.

Also, we unfortunately seem to have missed one failure: #2691

pizzarob pushed a commit to pizzarob/EIPs that referenced this pull request Jun 12, 2020
* Add iam to codespell-whitelist (used as a variable name)

* Allow french spelling in the whitelist

* Allow ACN (australian company number) in the whitelist

* Fix misspellings
tkstanczak pushed a commit to tkstanczak/EIPs that referenced this pull request Nov 7, 2020
* Add iam to codespell-whitelist (used as a variable name)

* Allow french spelling in the whitelist

* Allow ACN (australian company number) in the whitelist

* Fix misspellings
Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request Mar 6, 2021
* Add iam to codespell-whitelist (used as a variable name)

* Allow french spelling in the whitelist

* Allow ACN (australian company number) in the whitelist

* Fix misspellings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI fails for all builds due to current state of master
4 participants