Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BEGINSUB as unexecutable marker #2659

Merged
merged 1 commit into from
May 19, 2020
Merged

BEGINSUB as unexecutable marker #2659

merged 1 commit into from
May 19, 2020

Conversation

gcolvin
Copy link
Contributor

@gcolvin gcolvin commented May 19, 2020

This PR incorporates the proposed fix to prevent the EVM from stepping (as opposed to jumping) to BEGINSUB -- JUMPSUB transfers control to the instruction after BEGINSUB; BEGINSUB itself aborts. This PR does not prevent "jumping into subroutines."

EIP-2315 “Simple Subroutines for the EVM” - AnalysisPawel Bylica @chfast, Andrei Maiboroda @gumb0, and Alex Beregszaszi @axic.
https://ethereum-magicians.org/t/eip-2315-simple-subroutines-for-the-evm-analysis/4229

@eip-automerger eip-automerger merged commit 0553d9e into master May 19, 2020
pizzarob pushed a commit to pizzarob/EIPs that referenced this pull request Jun 12, 2020
Hi, I'm a bot! This change was automatically merged because:

 - It only modifies existing Draft or Last Call EIP(s)
 - The PR was approved or written by at least one author of each modified EIP
 - The build is passing
tkstanczak pushed a commit to tkstanczak/EIPs that referenced this pull request Nov 7, 2020
Hi, I'm a bot! This change was automatically merged because:

 - It only modifies existing Draft or Last Call EIP(s)
 - The PR was approved or written by at least one author of each modified EIP
 - The build is passing
Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request Mar 6, 2021
Hi, I'm a bot! This change was automatically merged because:

 - It only modifies existing Draft or Last Call EIP(s)
 - The PR was approved or written by at least one author of each modified EIP
 - The build is passing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants