EIP-2565: Repricing of the EIP-198 ModExp precompile #2565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
reviewed
Mar 22, 2020
axic
reviewed
Mar 22, 2020
axic
suggested changes
Mar 22, 2020
axic
reviewed
Mar 22, 2020
axic
reviewed
Mar 22, 2020
Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu>
ineffectualproperty
changed the title
|
Resolved issues, thanks for review/feedback. Please let me know if there are any other changed required. |
ineffectualproperty
changed the title
axic
reviewed
Mar 22, 2020
axic
reviewed
Mar 22, 2020
axic
suggested changes
Mar 24, 2020
axic
reviewed
Mar 24, 2020
axic
reviewed
Mar 24, 2020
axic
reviewed
Mar 24, 2020
axic
reviewed
Mar 24, 2020
Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu>
Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu>
Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu>
Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu>
Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu>
Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu>
Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu>
Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu>
Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu>
|
|
Added security considerations section and refined test cases section. Thank you for continued feedback, please review at your convenience. |
|
@axic let me know if you have any other feedback/questions. Appreciate your help reviewing! |
|
@ineffectualproperty it seems somehow the build was not triggered. Can you push again (just put in a whitespace change) ? |
axic
approved these changes
Mar 30, 2020
|
@axic done. all checks look good. thanks once again. |
pizzarob
pushed a commit
to pizzarob/EIPs
that referenced
this pull request
Jun 12, 2020
* assets * draft * added relative paths * simple typos * added discussion URL * v Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu> * fixes 'requires' field in eip header Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu> * Updates EIP name * Delete .DS_Store * delete .ds_store * Removed raw=true for images in markdown * delete ds_store * delete ds_store * small fixes * Added raw=true to pngs in md file * Added proposed complexity formula * minor fix for new complexity formula * minor markdown formatting for variable Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu> * minor markdown formatting Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu> * spelling fix Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu> * link fix for assigned EIP number Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu> * link fix for assigned EIP number Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu> * markdown formatting fix Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu> * link fix for assigned EIP number Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu> * fixed markdown formatting Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu> * use canonical EIP links Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu> * Added security considerations and refined test cases section * whitespace change to trigger build Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>
tkstanczak
pushed a commit
to tkstanczak/EIPs
that referenced
this pull request
Nov 7, 2020
* assets * draft * added relative paths * simple typos * added discussion URL * v Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu> * fixes 'requires' field in eip header Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu> * Updates EIP name * Delete .DS_Store * delete .ds_store * Removed raw=true for images in markdown * delete ds_store * delete ds_store * small fixes * Added raw=true to pngs in md file * Added proposed complexity formula * minor fix for new complexity formula * minor markdown formatting for variable Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu> * minor markdown formatting Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu> * spelling fix Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu> * link fix for assigned EIP number Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu> * link fix for assigned EIP number Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu> * markdown formatting fix Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu> * link fix for assigned EIP number Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu> * fixed markdown formatting Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu> * use canonical EIP links Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu> * Added security considerations and refined test cases section * whitespace change to trigger build Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>
Arachnid
pushed a commit
to Arachnid/EIPs
that referenced
this pull request
Mar 6, 2021
* assets * draft * added relative paths * simple typos * added discussion URL * v Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu> * fixes 'requires' field in eip header Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu> * Updates EIP name * Delete .DS_Store * delete .ds_store * Removed raw=true for images in markdown * delete ds_store * delete ds_store * small fixes * Added raw=true to pngs in md file * Added proposed complexity formula * minor fix for new complexity formula * minor markdown formatting for variable Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu> * minor markdown formatting Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu> * spelling fix Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu> * link fix for assigned EIP number Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu> * link fix for assigned EIP number Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu> * markdown formatting fix Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu> * link fix for assigned EIP number Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu> * fixed markdown formatting Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu> * use canonical EIP links Co-Authored-By: Alex Beregszaszi <alex@rtfs.hu> * Added security considerations and refined test cases section * whitespace change to trigger build Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This EIP propose a reduction in gas price for the ModExp (EIP-198) precompile