Abandon EIP-1706 #2543
Merged
Abandon EIP-1706 #2543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forshtat
force-pushed
the
supersede_1706
branch
from
ca7d72c
to
06613c3
Compare
|
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):
|
axic
reviewed
Mar 1, 2020
EIPS/eip-1706.md
Outdated
| @@ -3,12 +3,14 @@ eip: 1706 | |||
| title: Disable SSTORE with gasleft lower than call stipend | |||
| author: Alex Forshtat <alex@tabookey.com>, Yoav Weiss <yoav@tabookey.com> | |||
| discussions-to: https://github.com/alex-forshtat-tbk/EIPs/issues/1 | |||
| status: Draft | |||
| status: Superseded | |||
There was a problem hiding this comment.
According to EIP-1 "Superseded" applies to "Final" EIPs, e.g. the fitting one here would be "Abandoned" with perhaps a note that EIP-2200 is the preferred way.
There was a problem hiding this comment.
Changed status to 'abandoned'
axic
approved these changes
Apr 21, 2020
pizzarob
pushed a commit
to pizzarob/EIPs
that referenced
this pull request
Jun 12, 2020
* Mark 1706 as 'superseded' instead of 'draft' * Change 'superseded' to 'abandoned'
tkstanczak
pushed a commit
to tkstanczak/EIPs
that referenced
this pull request
Nov 7, 2020
* Mark 1706 as 'superseded' instead of 'draft' * Change 'superseded' to 'abandoned'
Arachnid
pushed a commit
to Arachnid/EIPs
that referenced
this pull request
Mar 6, 2021
* Mark 1706 as 'superseded' instead of 'draft' * Change 'superseded' to 'abandoned'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While 1706 was never 'final' on its own, I think keeping it as 'draft', or marking it 'abandoned' or 'rejected' creates a false perception that the logic specified in it never made it to the EVM.
EIP-2200 explicitly states it includes all provisions of this EIP word-by-word.