Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIPS eligible for Inclusion #2378

Merged
merged 6 commits into from
Jan 29, 2020
Merged

EIPS eligible for Inclusion #2378

merged 6 commits into from
Jan 29, 2020

Conversation

MadeofTin
Copy link
Contributor

Meta EIP for tracking Eligibility for Inclusion as defined in the EIP-centric Forking Model.

Meta EIP for tracking Eligibility for Inclusion as defined in the EIP-centric Forking Model.
EIPS/EIP-xxx.md Outdated Show resolved Hide resolved
EIPS/EIP-xxx.md Outdated
title: EIPS eligible for Inclusion
author: James Hancock (MadeofTin)
discussions-to: <URL>
status: Draft
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we say this is in Active status (e.g. a registry)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it go directly to Active? Or start as Draft and then be moved to Active?

EIPS/EIP-xxx.md Outdated Show resolved Hide resolved
EIPS/EIP-xxx.md Outdated Show resolved Hide resolved
EIPS/EIP-xxx.md Outdated Show resolved Hide resolved
@timbeiko
Copy link
Contributor

Could we merge this? Have been linking it to multiple people as the "official" resource of EIPs that are being considered. cc: @axic @MadeofTin

EIPS/eip-2378.md Outdated Show resolved Hide resolved
Given that this will be a registry EIP and the informational part will be moved out eventually. It made sense to me for the appropriate discussion about what EIPs are included should happen on the /ethereum/eip gitter channel.
@gcolvin gcolvin merged commit b788f38 into ethereum:master Jan 29, 2020
@axic
Copy link
Member

axic commented Jan 29, 2020

Could we merge this? Have been linking it to multiple people as the "official" resource of EIPs that are being considered.

We have agreed in December with @MadeofTin that this EIP should not propose a change in process (as the process just should be part of EIP-1 or EIP-233, because having multiple draft process EIPs is extremely confusing) and be only a listing. Was this change done?

@MadeofTin
Copy link
Contributor Author

Not yet. Adding it to EIP-1 is part of the plan of the EIPIP work, but Tim mentioned that not having a place to point people to see the registry has made working with it difficult. In my view the process changed when the ACD agreed to move to the EIP-Centric model. The description in 2378 was meant to be informational to those who don't know anything about the model. When I made it just as a registry it was unclear. The description in 2378 isn't sufficient to describe the actual process change which should take place in EIP-1.

Pulling the description out of here, before having the process change described in EIP in my view would add more confusion. As EIP-1 progresses we can remove it from here. I am still working on what is the best way to add it to EIP-1.

@MadeofTin
Copy link
Contributor Author

IMO: we should keep2378 as DRAFT until EIP-1 is updated and then be moved to ACTIVE.

pizzarob pushed a commit to pizzarob/EIPs that referenced this pull request Jun 12, 2020
* EIPS eligible for Inclusion

Meta EIP for tracking Eligibility for Inclusion as defined in the EIP-centric Forking Model.

* Spelling and formatting updates

* Formating Github Markdown

* Added number and responded to Feedback

* Update and rename EIP-2378.md to eip-2378.md

* EFI: Updated Discussion-to URL to the /EIP

Given that this will be a registry EIP and the informational part will be moved out eventually. It made sense to me for the appropriate discussion about what EIPs are included should happen on the /ethereum/eip gitter channel.
tkstanczak pushed a commit to tkstanczak/EIPs that referenced this pull request Nov 7, 2020
* EIPS eligible for Inclusion

Meta EIP for tracking Eligibility for Inclusion as defined in the EIP-centric Forking Model.

* Spelling and formatting updates

* Formating Github Markdown

* Added number and responded to Feedback

* Update and rename EIP-2378.md to eip-2378.md

* EFI: Updated Discussion-to URL to the /EIP

Given that this will be a registry EIP and the informational part will be moved out eventually. It made sense to me for the appropriate discussion about what EIPs are included should happen on the /ethereum/eip gitter channel.
Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request Mar 6, 2021
* EIPS eligible for Inclusion

Meta EIP for tracking Eligibility for Inclusion as defined in the EIP-centric Forking Model.

* Spelling and formatting updates

* Formating Github Markdown

* Added number and responded to Feedback

* Update and rename EIP-2378.md to eip-2378.md

* EFI: Updated Discussion-to URL to the /EIP

Given that this will be a registry EIP and the informational part will be moved out eventually. It made sense to me for the appropriate discussion about what EIPs are included should happen on the /ethereum/eip gitter channel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants