Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable editors #6650

Closed
Pandapip1 opened this issue Mar 8, 2023 · 12 comments
Closed

Customizable editors #6650

Pandapip1 opened this issue Mar 8, 2023 · 12 comments
Labels
enhancement w-stale Waiting on activity

Comments

@Pandapip1
Copy link
Member

Pandapip1 commented Mar 8, 2023

Proposed Change

In eip-review-bot, currently there are predefined editor groups depending on the type and category. I propose that, as a stop-gap solution before implementing tags, that we have a slightly more customizable editor list for peer reviewers.

@Pandapip1 Pandapip1 changed the title Customizable editorss Customizable editors Mar 14, 2023
@SamWilsn
Copy link
Contributor

What would this look like?

@xinbenlv
Copy link
Contributor

Can you elaborate what is being proposed here @Pandapip1

@Pandapip1
Copy link
Member Author

Basically, the config would be updated to look like this:

version: 2
editors:
    Pandapip1:
        - governance # Special category for governance
        - core
        - erc
        ...
    foobar: # Doesn't like NFTs
        - erc
        - !nft
    ...
categories:
    core:
        - category === "Core"
    erc:
        - category === "ERC"
    ...
    nft: # Example of some new features enabled by this
        - requires.split(",").some(eip => ["721", "1155"].includes(eip.trim()))
    

@xinbenlv
Copy link
Contributor

Is this for peer reviewing (technical feedback) or for editing?

@Pandapip1
Copy link
Member Author

Pandapip1 commented Mar 22, 2023

Both! If you want, I can also extend it so that there are more special categories (governance, editor, reviewer)

@SamWilsn
Copy link
Contributor

SamWilsn commented Apr 5, 2023

So !nft above removes NFT related topics from foobar's purview? Without tags, how does that work?

@Pandapip1
Copy link
Member Author

The config file specifies the pseudo-tags

@Pandapip1
Copy link
Member Author

Bump. Surprised the stale bot hasn't given any warnings.

@github-actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Sep 12, 2023
@Pandapip1
Copy link
Member Author

Weird... why did I get notified about #6650 (comment) now?

@github-actions github-actions bot removed the w-stale Waiting on activity label Sep 13, 2023
@github-actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Sep 21, 2023
Copy link

github-actions bot commented Nov 9, 2023

This issue was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement w-stale Waiting on activity
Projects
None yet
Development

No branches or pull requests

5 participants
@xinbenlv @Pandapip1 @SamWilsn and others