-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/batch-submitter: HTTP/2 fixes #2078
go/batch-submitter: HTTP/2 fixes #2078
Conversation
The built-in geth client has a bugger implementation of HTTP/2: ethereum/go-ethereum#24292. Additionally, Go 1.17 has better HTTP/2 support than Go 1.15. This PR updates the BSS to use Go 1.17 in built binaries, and adds a flag to disable HTTP/2 support if necessary.
🦋 Changeset detectedLatest commit: f0c3f93 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we won't need to run with disabling http2 once the next version of geth is released with that bug fix. Perhaps scope creep, but i don't think its a bad idea to configure the http client with a user agent that includes the version, this could be done simply by changing disableHTTP2
into httpOpts
and calling this: https://github.com/ethereum/go-ethereum/blob/015fde9a2c4b6e722a9de5bfea2a14226806a231/rpc/client.go#L267
Codecov Report
@@ Coverage Diff @@
## develop #2078 +/- ##
===========================================
- Coverage 77.35% 75.37% -1.98%
===========================================
Files 57 81 +24
Lines 1983 2705 +722
Branches 292 436 +144
===========================================
+ Hits 1534 2039 +505
- Misses 449 666 +217
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Update to go-ethereum v1.10.16. Release notes: https://github.com/ethereum/go-ethereum/releases/tag/v1.10.16 This notably fixes the http2 bug in the rpc client. #2078 will be able to be reverted after this is merged in
Update to go-ethereum v1.10.16. Release notes: https://github.com/ethereum/go-ethereum/releases/tag/v1.10.16 This notably fixes the http2 bug in the rpc client. #2078 will be able to be reverted after this is merged in
Update to go-ethereum v1.10.16. Release notes: https://github.com/ethereum/go-ethereum/releases/tag/v1.10.16 This notably fixes the http2 bug in the rpc client. ethereum-optimism#2078 will be able to be reverted after this is merged in
The built-in geth client has a bugger implementation of HTTP/2: ethereum/go-ethereum#24292. Additionally, Go 1.17 has better HTTP/2 support than Go 1.15. This PR updates the BSS to use Go 1.17 in built binaries, and adds a flag to disable HTTP/2 support if necessary.