-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use FallbackProvider in the DTL #1393
Merged
+88
−14
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'@eth-optimism/core-utils': patch | ||
'@eth-optimism/data-transport-layer': patch | ||
--- | ||
|
||
Add fallback provider support to DTL using helper function in core-utils |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
/** | ||
* Provider Utilities | ||
*/ | ||
|
||
import { ethers } from 'ethers' | ||
import { Provider } from '@ethersproject/providers' | ||
|
||
// Copied from @ethersproject/providers since it is not | ||
// currently exported | ||
export interface FallbackProviderConfig { | ||
// The Provider | ||
provider: Provider | ||
// The priority to favour this Provider; higher values are used first | ||
priority?: number | ||
// Timeout before also triggering the next provider; this does not stop | ||
// this provider and if its result comes back before a quorum is reached | ||
// it will be incorporated into the vote | ||
// - lower values will cause more network traffic but may result in a | ||
// faster retult. | ||
stallTimeout?: number | ||
// How much this provider contributes to the quorum; sometimes a specific | ||
// provider may be more reliable or trustworthy than others, but usually | ||
// this should be left as the default | ||
weight?: number | ||
} | ||
|
||
export const FallbackProvider = (config: string | FallbackProviderConfig[]) => { | ||
const configs = [] | ||
if (typeof config === 'string') { | ||
const urls = config.split(',') | ||
for (const [i, url] of urls.entries()) { | ||
configs.push({ | ||
priority: i, | ||
provider: new ethers.providers.StaticJsonRpcProvider(url), | ||
}) | ||
} | ||
return new ethers.providers.FallbackProvider(configs) | ||
} | ||
return new ethers.providers.FallbackProvider(config) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR to export the interface here: ethers-io/ethers.js#2121