fix: fix potential error when running without any argument in check-snapshots.sh #11812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, sorry for the delay here! Could you rebase this PR? I'll get it merged once that's done |
Hi @smartcontracts : thanks for your comment, the rebase is done now. |
smartcontracts
approved these changes
Oct 23, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Merged
via the queue into
ethereum-optimism:develop
with commit Oct 23, 2024
3159e0e
48 checks passed
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The fix improves robustness of the script.
The orginal script assumes that $1 will always be set. If the script is run without any arguments, this will produce an error due to set -u (which treats unset variables as an error).
To fix this, before comparing it, whether $1 is set is checked
Tests
Local test has been performed, no issue found