feat/custom gas token: diego's changes

[0xfuturistic]

No description provided.

[coderabbitai]

Walkthrough

The recent updates across multiple contracts in the contracts-bedrock package involve version changes and enhancements related to gas token handling, version strings, and validation mechanisms. These updates aim to improve compatibility, provide additional information in version strings, and strengthen validation processes for gas-paying tokens.

Changes

File	Summary
.../L1/OptimismPortal.sol, .../L1/L1CrossDomainMessenger.sol, .../L1/L1StandardBridge.sol	Updated version constants to include beta tags and custom gas token information.
.../L1/SystemConfig.sol	Enhanced SystemConfig contract with a new version string and added validation for gas-paying tokens.
.../L2/L1Block.sol	Updated version constant with beta tag and custom gas token info, along with removal of the previous version constant.
.../L2/L2CrossDomainMessenger.sol, .../L2/L2StandardBridge.sol	Updated version constants to include beta tags and custom gas token information.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

[semgrep-app]

Semgrep found 1 sol-style-input-arg-fmt finding:

• packages/contracts-bedrock/scripts/DeployConfig.s.sol
  • L212 - Triage

Inputs to functions must be prepended with an underscore (_)

_{Ignore this finding from sol-style-input-arg-fmt.}

[coderabbitai]

Actionable comments posted: 1

[coderabbitai]

Ensure robust error handling for ERC20 token methods in _setGasPayingToken.

Consider adding try-catch blocks around calls to ERC20(_token).decimals(), ERC20(_token).name(), and ERC20(_token).symbol() to handle cases where these methods are not implemented by the token contract.

[tynes]

Pulled into upstream PR :)