This repository has been archived by the owner on Feb 18, 2025. It is now read-only.
feat(isthmus): verify storage root in execution #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Contributions welcome! See https://github.com/ethereum-optimism/.github/blob/master/CONTRIBUTING.md --> **Description** Merges down and cleans up changes to ci from isthmus-devnet-0 branch. Ref #8. - Removes jobs: for L1, for deploying, some maintenance jobs - Removes cron jobs **Tests** <!-- Please describe any tests you've added. If you've added no tests, or left important behavior untested, please explain why not. --> **Additional context** <!-- Add any other context about the problem you're solving. --> **Metadata** <!-- Include a link to any github issues that this may close in the following form: - Fixes #[Link to Issue] -->
emhane
added
D-isthmus-devnet-0
<!-- Contributions welcome! See https://github.com/ethereum-optimism/.github/blob/master/CONTRIBUTING.md --> **Description** Adds back hive assets reused in workflow `kurtosis-op`. **Tests** <!-- Please describe any tests you've added. If you've added no tests, or left important behavior untested, please explain why not. --> **Additional context** https://github.com/ethereum-optimism/op-reth/actions/runs/12640451509/job/35220890751 **Metadata** <!-- Include a link to any github issues that this may close in the following form: - Fixes #[Link to Issue] -->
|
pending op-node upgrade https://github.com/ethereum-optimism/op-reth/actions/runs/12642532357 |
emhane
force-pushed
the
isthmus-devnet-0
branch
from
b03e69b to
56eb5b1
Compare
emhane
force-pushed
the
emhane/exec-verif-storage-root
branch
2 times, most recently
from
a8af08c to
6a44381
Compare
emhane
force-pushed
the
isthmus-devnet-0
branch
from
dd44bb7 to
e7de9e0
Compare
…is proxies address
emhane
force-pushed
the
emhane/exec-verif-storage-root
branch
from
b83ce1b to
2ba9fa1
Compare
Defines `OpExecutionPayloadValidator` for replacing use of l1 `ExecutionPayloadValidator` in `OpEngineValidator`. New type doesn't compute withdrawals root from empty withdrawals list, but instead has reference to the database and retrieves storage root of l2tol1 message passing contract instead.
This was referenced Jan 30, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4, #5
Supersedes #3
Moves isthmus storage root verification into execution, instead of after execution. This way storage root verification can happen for batch executed blocks in pipeline sync, as well as in live sync. Furthermore it requires less changes to reth's and op-reth's shared type system.