Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chains.json order #61

Closed
pedrouid opened this issue May 8, 2019 · 5 comments
Closed

Fix chains.json order #61

pedrouid opened this issue May 8, 2019 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@pedrouid
Copy link
Collaborator

pedrouid commented May 8, 2019

The generated JSON file at https://chainid.network/chains.json needs to be ordered by chain_id
@ligi ligi added the enhancement New feature or request label May 9, 2019
@ligi ligi added good first issue Good for newcomers help wanted Extra attention is needed labels May 17, 2019
@pedrouid pedrouid mentioned this issue May 21, 2019
Closed
ligi added a commit that referenced this issue May 22, 2019
@ligi
Add nativeCurrency - closes #66 and add chains_mini.json
5f96651 
also improves #61 - at least now mainnet is on top again ;-)
ligi added a commit that referenced this issue May 22, 2019
@ligi
Add nativeCurrency - closes #66 and add chains_mini.json
150aa21 
also improves #61 - at least now mainnet is on top again ;-)
@ligi
Copy link
Member

ligi commented May 22, 2019

progressed a bit here - at least chain 1 is on top again ;-)

@wbt wbt mentioned this issue May 25, 2020
Open
@ligi
Copy link
Member

ligi commented May 26, 2020

After the discussion in #97 I wonder if we really need to have it sorted in the json or if it is enough to have it sorted in the website

@curtcurt871
Copy link

https://cryptoitcraz.io

@Systemfehler1979

This comment was marked as spam.

Sign in to view
ligi added a commit that referenced this issue Jul 11, 2021
@ligi
Sort chains by chainID in json files - closes #61
449a39e
@ligi ligi closed this as completed in 4ea7eef Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Order chains by chain_id ethereum-lists/chains
5 participants
@ligi @pedrouid @curtcurt871 @Systemfehler1979 and others