Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for v1 release #394

Merged
merged 10 commits into from
Nov 4, 2024
Merged

Fixes for v1 release #394

merged 10 commits into from
Nov 4, 2024

Conversation

ethanmoffat
Copy link
Owner

Thanks @Cirras for testing! This fixes the following discovered issues:

  • Quick repeated click events not activating
    • cause: DoubleClick event was suppressing normal clicks
    • fix: Use MouseDown events for all clicks instead of MouseClick (see next bullet)
  • Vanilla client uses MouseDown while EndlessClient uses MouseClick
    • fix: Implement detection of MouseDown, replace MouseClick event handlers with MouseDown handlers
  • ESC doesn't clear input boxes
    • fix: Implement KeyPress/KeyRelease event handling, detect Esc key via base ClearableTextBox class in EndlessClient
  • Selecting character via keyboard shortcut doesn't play a sound
    • fix: Add sfxPlayer call to keyboard shortcut
  • Returning to main menu stops background music
    • fix: Only stop background music on transition from PlayingTheGame state
  • Unable to get past character select screen
    • fix: TBD
    • improved error handling for async tasks and pop up friendly error message dialog with GitHub report link

@ethanmoffat ethanmoffat added this to the Version 1 milestone Nov 4, 2024
@ethanmoffat ethanmoffat merged commit e5a99d2 into master Nov 4, 2024
3 checks passed
@ethanmoffat ethanmoffat deleted the release_fixes branch November 4, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant