Dotnet format #368
Merged
Dotnet format #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MrDanOak
commented
Jul 31, 2024
•
MrDanOak
commented
- add .editoconfig with sensible defaults
- run dotnet format on the solution
MrDanOak
commented
Jul 31, 2024
MrDanOak
commented
Jul 31, 2024
ethanmoffat
reviewed
Aug 1, 2024
There was a problem hiding this comment.
Starting with these two suggestions - I think that'll reduce most of the code churn in the PR and aligns with my preferred style. I'd like to make introduction of a formatter as unintrusive as possible. It'll make it easier to see the impact of the other editorconfig settings if there isn't as much using reorder noise or newlines at the ends of files being deleted.
docs: update readme about building on mac
ethanmoffat
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Thanks so much for this, this will make my life significantly easier when reviewing PRs. I was hoping that the usings/file EOL were more consistent than they were - too bad this has to touch so many files, but seems like it's unavoidable. Guess we're ripping off the band-aid!
ethanmoffat
pushed a commit
that referenced
this pull request
Aug 5, 2024
This change adds auto-formatting for the solution. Formatting can be executed via the `dotnet format <sln_name>` command. Changes that do not comply with the formatting expectations set in the editorconfig will fail. Also adds: - global.json file for selecting 6.0 sdk - eol setting for gitattributes so checkouts work properly cross-platform with the editorconfig changes - readme updates
ethanmoffat
pushed a commit
that referenced
this pull request
Aug 6, 2024
This change adds auto-formatting for the solution. Formatting can be executed via the `dotnet format <sln_name>` command. Changes that do not comply with the formatting expectations set in the editorconfig will fail. Also adds: - global.json file for selecting 6.0 sdk - eol setting for gitattributes so checkouts work properly cross-platform with the editorconfig changes - readme updates
ethanmoffat
pushed a commit
that referenced
this pull request
Aug 6, 2024
This change adds auto-formatting for the solution. Formatting can be executed via the `dotnet format <sln_name>` command. Changes that do not comply with the formatting expectations set in the editorconfig will fail. Also adds: - global.json file for selecting 6.0 sdk - eol setting for gitattributes so checkouts work properly cross-platform with the editorconfig changes - readme updates
ethanmoffat
added a commit
that referenced
this pull request
Aug 7, 2024
* Reboot handler (#362) Add Message_Close handler, reboot event notifier, and reboot sound effect id * Dotnet format (#368) This change adds auto-formatting for the solution. Formatting can be executed via the `dotnet format <sln_name>` command. Changes that do not comply with the formatting expectations set in the editorconfig will fail. Also adds: - global.json file for selecting 6.0 sdk - eol setting for gitattributes so checkouts work properly cross-platform with the editorconfig changes - readme updates --------- Co-authored-by: Richard Leek <richard@richardleek.com> Co-authored-by: Dan Oak <464887+MrDanOak@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.