[fulen] Fix GDB 7.10.1 and add GBD 8.1.1 #807
Conversation
victorusu
changed the title
|
retest this please |
| source_urls = ['http://mirror.switch.ch/ftp/mirror/gnu/gdb/'] | ||
| sources = [SOURCELOWER_TAR_XZ] | ||
|
|
||
| toolchain = {'name': 'dummy', 'version': 'dummy'} |
There was a problem hiding this comment.
version should be empty or dependencies are not loaded
There was a problem hiding this comment.
I made it dummy, because I think GDB should not be a dependency ever.
But I can change it to ''.
There was a problem hiding this comment.
Let me rephrase that: the tc version should be empty (i'm not referring to the name) or the dependencies (inside this eb file) are not loaded (unless eb has recently changed this behaviour, this recipe is using ncurses from the system and not from eb).
There was a problem hiding this comment.
I think that setting 'version': 'dummy' affects the use of the GBD as a dependency, but not the use of dependencies within GDB. Because I can see the module load ncurses command inside the generated GDB module
module show GDB/8.1.1
-------------------------------------------------------------------
/apps/.../GDB/8.1.1:
module-whatis Description: The GNU Project Debugger
module-whatis Homepage: http://www.gnu.org/software/gdb/gdb.html
conflict GDB
module load ncurses/.6.0
...
There was a problem hiding this comment.
Did you check also during the load occurs during the build process?
EB not loading the dependencies when the toolchain version is defined is a known issue and we had to chang many recipes because of this.
If this behaviour changed, we should confirm (ideally asking @boegel and identifying the PR that touched that) and then inform all the team.
There was a problem hiding this comment.
Using dummy as version means that the dependencies won't be loaded during the build, but the will be included in the generated module file, see also https://easybuild.readthedocs.io/en/latest/Writing_easyconfig_files.html#loading-of-modules-for-dependencies-with-a-dummy-toolchain .
Long story short: always use '' as version when using dummy toolchain. The behavior with the dummy version is a historical, which we intend to rectify with the system toolchain concept which is supposed to replace dummy, see easybuilders/easybuild-framework#1181 (it'll happen some day, will put this back on the agenda for EB v4.0 (see easybuilders/easybuild#447)).
There is a missing patch for GDB 7.10.1