Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TridiagSolver (dist): STEP2 Make rank1 work just on local non-deflated eigenvectors #996

Merged
merged 9 commits into from
Dec 12, 2023
Merged

TridiagSolver (dist): STEP2 Make rank1 work just on local non-deflated eigenvectors #996

merged 9 commits into from
Dec 12, 2023

Conversation

albestro
Copy link
Collaborator

@albestro albestro commented Sep 29, 2023 •
edited
Loading

  • stablePartitionIndex now computes k_lc together with i6 and i2 needed by rank1
  • rank1 solver is single-threaded (next PR will make it multithreaded)

TODO

  • snake_case
  • fix doc
  • check TODO

@albestro albestro added this to the Optimizations milestone Sep 29, 2023
@albestro albestro self-assigned this Sep 29, 2023
@albestro albestro force-pushed the alby/trisolver-sort-for-gemm-dist branch from b1d0c7e to e80f01a Compare September 29, 2023 10:13
@albestro albestro force-pushed the alby/trisolver-dist-opt-step2 branch from c22b56f to 42d6681 Compare September 29, 2023 10:16
albestro added a commit that referenced this pull request Oct 16, 2023
@albestro
Develop: TridagSolver (dist): multi branch
dc23ee0 
Develop: TridiagSolver (dist): STEP1 rank-independent sort of eigenvalues by column type for rank1 solver (#967)
Develop: TridiagSolver (dist): STEP2 Make rank1 work just on local non-deflated eigenvectors (#996)
Develop: TridiagSolver (dist): STEP2b Make rank1 work just on local non-deflated eigenvectors (multi-threaded) (#997)
Develop: TridiagSolver (dist): STEP3 reduce GEMM step computational cost (#998)
@albestro albestro force-pushed the alby/trisolver-sort-for-gemm-dist branch 2 times, most recently from 61b3265 to 51109c9 Compare December 4, 2023 15:17
@albestro albestro force-pushed the alby/trisolver-dist-opt-step2 branch from 42d6681 to 477b2e2 Compare December 4, 2023 15:17
Base automatically changed from alby/trisolver-sort-for-gemm-dist to master December 11, 2023 10:15
@albestro albestro force-pushed the alby/trisolver-dist-opt-step2 branch from 477b2e2 to 0d17094 Compare December 11, 2023 10:44
@albestro albestro marked this pull request as ready for review December 11, 2023 10:45
@albestro albestro requested review from rasolca and msimberg December 11, 2023 10:45
albestro
albestro commented Dec 11, 2023
View reviewed changes
include/dlaf/eigensolver/tridiag_solver/merge.h Outdated Show resolved Hide resolved
include/dlaf/eigensolver/tridiag_solver/merge.h Outdated Show resolved Hide resolved
include/dlaf/eigensolver/tridiag_solver/merge.h Outdated Show resolved Hide resolved
include/dlaf/eigensolver/tridiag_solver/merge.h Outdated Show resolved Hide resolved
include/dlaf/eigensolver/tridiag_solver/merge.h Outdated Show resolved Hide resolved
include/dlaf/eigensolver/tridiag_solver/merge.h Outdated Show resolved Hide resolved
msimberg
msimberg approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't comment on the algorithm specifics as usual, the rest look all good to me.

@albestro
Copy link
Collaborator Author

cscs-ci run

@codecov-commenter
Copy link

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (b99bb16) 94.05% compared to head (84efe67) 93.99%.
Report is 1 commits behind head on master.

Files Patch % Lines
include/dlaf/eigensolver/tridiag_solver/merge.h 95.97% 2 Missing and 5 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #996      +/-   ##
==========================================
- Coverage   94.05%   93.99%   -0.06%     
==========================================
  Files         145      145              
  Lines        9068     9032      -36     
  Branches     1160     1159       -1     
==========================================
- Hits         8529     8490      -39     
+ Misses        321      320       -1     
- Partials      218      222       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albestro albestro mentioned this pull request Dec 12, 2023
Merged
2 tasks
@rasolca rasolca merged commit e312c25 into master Dec 12, 2023
3 checks passed
@rasolca rasolca deleted the alby/trisolver-dist-opt-step2 branch December 12, 2023 09:45
github-actions bot pushed a commit that referenced this pull request Dec 12, 2023
@rasolca
Doc: TridiagSolver (dist): STEP2 Make rank1 work just on local non-de…
7ea673d 
…flated eigenvectors (#996)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasolca rasolca rasolca approved these changes

@msimberg msimberg msimberg approved these changes

Assignees

@albestro albestro

Labels
Priority:High
Projects
DLA-F Planning
Archived in project
Milestone
Optimizations
Development

Successfully merging this pull request may close these issues.
4 participants
@albestro @codecov-commenter @msimberg @rasolca