Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use slightly fewer threads for pika in CI #1269

Closed
wants to merge 1 commit into from

Conversation

msimberg
Copy link
Collaborator

@msimberg msimberg commented Feb 6, 2025

Requires pika 0.32.0 for the PIKA_THREADS environment variable to have an effect.

@msimberg msimberg self-assigned this Feb 6, 2025
@msimberg
Copy link
Collaborator Author

msimberg commented Feb 6, 2025

cscs-ci run

@msimberg
Copy link
Collaborator Author

msimberg commented Feb 6, 2025

Leaving one core free for other threads in this PR also speeds up the C API tests quite a bit (in addition to #1268). Setting PIKA_THREADS requires pika 0.32.0, so it won't apply to all CI configurations (we want to keep one on the oldest supported version 0.30.X), but we could use 0.32.0 on the CUDA configurations where there are more tests to run.

@RMeli
Copy link
Member

RMeli commented Feb 7, 2025

Setting PIKA_THREADS requires pika 0.32.0, so it won't apply to all CI configurations

Ugly, but can't you still use the workaround PIKA_COMMANDLINE_OPTIONS="--pika:threads=..." which works with earlier versions too?

@msimberg
Copy link
Collaborator Author

Setting PIKA_THREADS requires pika 0.32.0, so it won't apply to all CI configurations

Ugly, but can't you still use the workaround `PIKA_COMMANDLINE_OPTIONS="--pika:threads=..." which works with earlier versions too?

In theory that should've been possible, but the real command line options and those supplied by PIKA_COMMANDLINE_OPTIONS do not mix well... (overriding each other, but not quite).

@msimberg msimberg force-pushed the ci-fewer-pika-threads branch from 38f7f82 to 95012fd Compare February 13, 2025 13:38
@msimberg
Copy link
Collaborator Author

cscs-ci run

@msimberg
Copy link
Collaborator Author

This doesn't seem to be making much of a difference on the C API tests anymore now that DLAF and pika are restarted much less frequently after #1268. Closing.

@msimberg msimberg closed this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants