-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update release procedure #1250
base: master
Are you sure you want to change the base?
Update release procedure #1250
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the 0.7.2 release, let's add at least the following
- always add release notes to the master branch even for patch releases to avoid mismatch between release and master branch
- always cherry pick changes from master to release branch (changes and release notes)
- can we add something about checking the release branch to make sure it matches what's in the release notes? (at the very least a manual inspection check to compare the release branch to the previous release?)
I would add to not release until tests passed. I.e. wait that the tests complete for master (major release) or the version branch (minor and patch). |
Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
For patch releases maybe we should add a step to also add branch protection rules? Currently only |
Should we mention something about using GitHub's milestones for a release? Currently they're not mentioned, but we sort of use them. I created one for 0.7.3 now: https://github.com/eth-cscs/DLA-Future/milestone/31. |
Idea from @RMeli: check automatically that the release branch has non-trivial commits since the previous version tag. Perhaps checking for changes to cpp and other source files in the Then again, we should not go completely overboard with checks either... |
I think I didn't explain myself well, but what I meant was to add a check to the release script to ensure that the tests (CI) have passed, if this is at all queryable with
|
TheCHANGELOG
inmaster
does not contain release notes for0.7.1
. Add this step to theRELEASE_PROCEDURE
.Improve release procedure, especially for patch releases. (Lessons learned...)