Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event return types and comparisons #919

Merged
merged 2 commits into from
Jan 4, 2021
Merged

Event return types and comparisons #919

merged 2 commits into from
Jan 4, 2021

Conversation

iamdefinitelyahuman
Copy link
Member

What I did

  • use ReturnValue instead of List for some return types related to events.
  • Allow direct comparison of a sequence with an _EventItem. The comparison assumes a check against the values within the event, in the same order as they're given in the ABI.

How to verify it

Run tests.

@iamdefinitelyahuman iamdefinitelyahuman merged commit e9f5360 into master Jan 4, 2021
@iamdefinitelyahuman iamdefinitelyahuman deleted the feat-event-types branch January 4, 2021 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@iamdefinitelyahuman